Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test_runner] metrics.json file is overwritten multiple times in the same shard #145793

Open
godofredoc opened this issue Mar 26, 2024 · 2 comments
Open

[test_runner] metrics.json file is overwritten multiple times in the same shard #145793

godofredoc opened this issue Mar 26, 2024 · 2 comments
Assignees
@godofredoc
Labels
a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
Infra - pay technical debt

Comments

@godofredoc
Copy link
Contributor

When running shard tests every execution of dart test, flutter test try to add their output to the same file in /metrics.json causing problems parsing the results and adding garbled content. Instead the files should be generated in a temporary folder.
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team a: tests "flutter test", flutter_test, or one of our tests team-infra Owned by Infrastructure team and removed in triage Presently being triaged by the triage team labels Mar 27, 2024
@keyonghan
Copy link
Contributor

I believe we have same issues for other log files uploaded to GCS.

@keyonghan keyonghan added P2 Important issues not at the top of the work list triaged-infra Triaged by Infrastructure team labels Mar 28, 2024
@keyonghan keyonghan added this to To do in Infra - pay technical debt via automation Mar 28, 2024
@godofredoc
Copy link
Contributor Author

This is different, metrics file should be used only within the test runner.

godofredoc added a commit to godofredoc/flutter that referenced this issue Mar 28, 2024
@godofredoc
Generate test metrics consistently.
0bf0dd8 
Starts creating metric files consistently for web, dart and flutter
runners. It also starts creating the files in the temp folder instead of
the checkout one.

Bug: flutter#145793
@godofredoc godofredoc mentioned this issue Mar 28, 2024
Merged
9 tasks
@godofredoc godofredoc self-assigned this Mar 29, 2024
@godofredoc godofredoc changed the title metrics.json file is overwritten multiple times in the same shard [test_runner] metrics.json file is overwritten multiple times in the same shard Mar 29, 2024
godofredoc added a commit to godofredoc/flutter that referenced this issue Mar 29, 2024
@godofredoc
Generate test metrics consistently.
c071f67 
Starts creating metric files consistently for web, dart and flutter
runners. It also starts creating the files in the temp folder instead of
the checkout one.

Bug: flutter#145793
auto-submit bot pushed a commit that referenced this issue Mar 29, 2024
@godofredoc
Generate test metrics consistently. (#145943)
7f66856 
Starts creating metric files consistently for web, dart and flutter runners. It also starts creating the files in the temp folder instead of the checkout one.

Bug: #145793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@godofredoc godofredoc

Labels
a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
Infra - pay technical debt
  
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@godofredoc @keyonghan @danagbemava-nc