Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interactive_media_ads] Add Swift Package Manager compatibility to interactive_media_ads #146906

Closed
2 tasks done
Tracked by #146922
vashworth opened this issue Apr 17, 2024 · 1 comment · Fixed by flutter/packages#6756
Closed
2 tasks done
Tracked by #146922

[interactive_media_ads] Add Swift Package Manager compatibility to interactive_media_ads #146906

vashworth opened this issue Apr 17, 2024 · 1 comment · Fixed by flutter/packages#6756
Assignees
@stuartmorgan
Labels
a: plugins Support for writing, building, and running plugin packages P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@vashworth
Copy link
Contributor

vashworth commented Apr 17, 2024 •
edited by stuartmorgan

Prerequisites:

Follow "Converting an existing Swift Flutter Plugin to a Swift Package" instructions to make interactive_media_ads plugin compatible with Swift Package Manager and CocoaPods.

To validate all is working, run the following commands

// Disable swift package manager
flutter config --no-enable-swift-package-manager

// Build example with CocoaPods
dart run script/tool/bin/flutter_plugin_tools.dart build-examples --ios --packages=interactive_media_ads

// Build example with swift package manager
dart run script/tool/bin/flutter_plugin_tools.dart build-examples --ios --swift-package-manager --packages=interactive_media_ads

// Run native tests
dart run script/tool/bin/flutter_plugin_tools.dart native-test --ios --packages=interactive_media_ads
@vashworth vashworth added platform-ios iOS applications specifically a: plugins Support for writing, building, and running plugin packages labels Apr 17, 2024
@vashworth vashworth mentioned this issue Apr 17, 2024
Open
19 tasks
@vashworth vashworth added P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team fyi-ecosystem For the attention of Ecosystem team labels Apr 17, 2024
@stuartmorgan stuartmorgan added the triaged-ecosystem Triaged by Ecosystem team label Apr 23, 2024
@flutter-triage-bot flutter-triage-bot bot removed fyi-ecosystem For the attention of Ecosystem team triaged-ecosystem Triaged by Ecosystem team labels Apr 23, 2024
@stuartmorgan stuartmorgan self-assigned this May 17, 2024
stuartmorgan added a commit to stuartmorgan/packages that referenced this issue May 17, 2024
@stuartmorgan
[interactive_media_ads] Add SPM support
eb6df7f 
Restructures the placeholder iOS implementation to follow the Swift
Package Manager layout, and enables SPM support.

Also marks the plugin as unpublished since it's not ready for
incremental changes to be published yet.

Fixes flutter/flutter#146906
stuartmorgan added a commit to stuartmorgan/packages that referenced this issue May 17, 2024
@stuartmorgan
[interactive_media_ads] Add SPM support
1073c2b 
Restructures the placeholder iOS implementation to follow the Swift
Package Manager layout, and enables SPM support.

Also marks the plugin as unpublished since it's not ready for
incremental changes to be published yet.

Fixes flutter/flutter#146906
@stuartmorgan stuartmorgan mentioned this issue May 17, 2024
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue May 21, 2024
@stuartmorgan
[interactive_media_ads] Add SPM support (#6756)
ef756da 
Restructures the placeholder iOS implementation to follow the Swift Package Manager layout, and enables SPM support.

Also marks the plugin as unpublished since it's not ready for incremental changes to be published yet.

Fixes flutter/flutter#146906
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this issue May 22, 2024
@stuartmorgan @TecHaxter
[interactive_media_ads] Add SPM support (flutter#6756)
d84b5a9 
Restructures the placeholder iOS implementation to follow the Swift Package Manager layout, and enables SPM support.

Also marks the plugin as unpublished since it's not ready for incremental changes to be published yet.

Fixes flutter/flutter#146906
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan stuartmorgan

Labels
a: plugins Support for writing, building, and running plugin packages P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[interactive_media_ads] Add SPM support stuartmorgan/packages
2 participants
@stuartmorgan @vashworth