getCountryCode methods are not implementing countryCode platform interface method

[vmeretin]

What package does this bug report belong to?

in_app_purchase

What target platforms are you seeing this bug on?

Android, iOS

Have you already upgraded your packages?

Yes

Dependency versions

pubspec.lock

  in_app_purchase:
    dependency: "direct main"
    description:
      name: in_app_purchase
      sha256: "960f26a08d9351fb8f89f08901f8a829d41b04d45a694b8f776121d9e41dcad6"
      url: "https://pub.dev"
    source: hosted
    version: "3.2.0"
  in_app_purchase_android:
    dependency: transitive
    description:
      name: in_app_purchase_android
      sha256: "15800e366f80bc8e5e15b960f52aac337722e3c5d9a46bf1157d010cfc606938"
      url: "https://pub.dev"
    source: hosted
    version: "0.3.4"
  in_app_purchase_platform_interface:
    dependency: transitive
    description:
      name: in_app_purchase_platform_interface
      sha256: "1d353d38251da5b9fea6635c0ebfc6bb17a2d28d0e86ea5e083bf64244f1fb4c"
      url: "https://pub.dev"
    source: hosted
    version: "1.4.0"
  in_app_purchase_storekit:
    dependency: transitive
    description:
      name: in_app_purchase_storekit
      sha256: eee35ad057c91f6d0e08db840ade03a9db6121beb03469590296f719f5936e68
      url: "https://pub.dev"
    source: hosted
    version: "0.3.14"

Steps to reproduce

Upgrade in_app_purchase to 3.2.0 version

Expected results

InAppPurchasePlatform.instance.countryCode() is working

Actual results

InAppPurchasePlatform.instance.countryCode() is not working

Code sample

Code sample

InAppPurchasePlatform.instance.countryCode()

Screenshots or Videos

Screenshots / Video demonstration

[Upload media here]

Logs

Logs

[Paste your logs here]

Flutter Doctor output

Doctor output

[✓] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale ru-RU)
    • Flutter version 3.19.5 on channel stable at /Users/vmeretin/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (4 weeks ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/vmeretin/dev/android-sdk/
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/vmeretin/dev/android-sdk/
    • ANDROID_SDK_ROOT = /Users/vmeretin/dev/android-sdk/
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] IntelliJ IDEA Community Edition (version 2024.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 79.0.3
    • Dart plugin version 241.15845

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.4.1 23E224 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 124.0.6367.62
    ! Error: Browsing on the local area network for vmeretin. Ensure the device is unlocked and attached with a
      cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[darshankawar]

@vmeretin
This PR seems to have recently merged flutter/packages#6540.
The plugin changelog does show that countryCode api is added: https://pub.dev/packages/in_app_purchase/changelog#320

Check the same in latest master version and with latest plugin version.

[vmeretin]

In platform interface method is called countryCode , but in platform implementations method is called getCountryCode (Android) and getCountryCode (iOS).

So method is not working correctly and always throw UnimplementedError.

[darshankawar]

Thanks for the update.

[stuartmorgan]

I missed that the implementation PR didn't @override, which would have turned this into an analyzer error.

[reidbaker]

@vmeretin thank you for the bug and I am embarrassed I messed this up. Fix coming in shortly.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.