Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] create explicit skia variants for benchmarks #147671

Open
gaaclarke opened this issue May 1, 2024 · 1 comment
Open

[Impeller] create explicit skia variants for benchmarks #147671

gaaclarke opened this issue May 1, 2024 · 1 comment
Labels
e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@gaaclarke
Copy link
Member

gaaclarke commented May 1, 2024 •
edited

After impeller android is switched on by default we will need to explicitly create skia variants of our benchmarks (since the existing benchmarks will be transitioned over to skia). When we did the switch iOS we hand picked some benchmarks to bring over. Options listed were: the new gallery, platform views.
@gaaclarke gaaclarke added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels May 1, 2024
@jonahwilliams jonahwilliams added the P2 Important issues not at the top of the work list label May 6, 2024
@jonahwilliams
Copy link
Member

Holding off until post 3.22 stable release.

@jonahwilliams jonahwilliams added the triaged-engine Triaged by Engine team label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonahwilliams @gaaclarke