Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SceneBuilder.pushImageFilter does not apply itself to the mutator for platform views #147908

Open
Hixie opened this issue May 7, 2024 · 0 comments
Open

SceneBuilder.pushImageFilter does not apply itself to the mutator for platform views #147908

Hixie opened this issue May 7, 2024 · 0 comments
Labels
a: platform-views Embedding Android/iOS views in Flutter apps P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@Hixie
Copy link
Contributor

Hixie commented May 7, 2024

@jonahwilliams actually, it looks like the mutator stack used for platform views doesn't have a concept of an image filter
@jonahwilliams so color_filter_layer.cc calls mutator.applyColorFilter(paint_bounds(), filter);
@jonahwilliams but image filter layer doesn't

pushImageFilter should be a string superset of pushColorFilter, because every ColorFilter is an ImageFilter.
@Hixie Hixie added a: platform-views Embedding Android/iOS views in Flutter apps P2 Important issues not at the top of the work list team-engine Owned by Engine team labels May 7, 2024
@jonahwilliams jonahwilliams added the triaged-engine Triaged by Engine team label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: platform-views Embedding Android/iOS views in Flutter apps P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hixie @jonahwilliams