Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] AHB "present ready" fence is not tracked till the completion of the command buffer. #147930

Open
chinmaygarde opened this issue May 7, 2024 · 1 comment
Open

[Impeller] AHB "present ready" fence is not tracked till the completion of the command buffer. #147930

chinmaygarde opened this issue May 7, 2024 · 1 comment
Labels
e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@chinmaygarde
Copy link
Member

Right now, the fence waiter takes a unique pointer to a fence we only have a shared handle. The fence waiter must be reworked for shared handles and the encoder in the AHB swapchain must be held till that fence is signaled.
@chinmaygarde chinmaygarde added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels May 7, 2024
@chinmaygarde
Copy link
Member Author

Followup on flutter/engine#52588. I'll be on the hook for cleaning this one up. Want to keep the other patch on point.

@jonahwilliams jonahwilliams added P2 Important issues not at the top of the work list triaged-engine Triaged by Engine team labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chinmaygarde @jonahwilliams