Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[et] compilation errors aren't colorful #147931

Open
gaaclarke opened this issue May 7, 2024 · 0 comments
Open

[et] compilation errors aren't colorful #147931

gaaclarke opened this issue May 7, 2024 · 0 comments
Labels
e: engine-tool Engine-specific tooling (i.e. `tools/engine_tool`). P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@gaaclarke
Copy link
Member

gaaclarke commented May 7, 2024 •
edited

Not having color output makes it more difficult to quickly scan the output and find the errors.

seen results

Screenshot 2024-05-07 at 10 25 03 AM

expected results

I expect the clang compilation error to have color, like ninja did when running it directly.
@gaaclarke gaaclarke added team-engine Owned by Engine team e: engine-tool Engine-specific tooling (i.e. `tools/engine_tool`). labels May 7, 2024
@jonahwilliams jonahwilliams added P3 Issues that are less important to the Flutter project triaged-engine Triaged by Engine team labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e: engine-tool Engine-specific tooling (i.e. `tools/engine_tool`). P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonahwilliams @gaaclarke