Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support changing textAlign of TextField in DropdownMenu #147991

Open
angelocordero opened this issue May 8, 2024 · 1 comment
Open

support changing textAlign of TextField in DropdownMenu #147991

angelocordero opened this issue May 8, 2024 · 1 comment
Assignees
@angelocordero
Labels
a: text input Entering text in a text field or keyboard related problems c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. fyi-design For the attention of Design Languages team P2 Important issues not at the top of the work list team-text-input Owned by Text Input team triaged-text-input Triaged by Text Input team

Comments

@angelocordero
Copy link
Contributor

Use case

DropdownMenu is a replacement to DropdownButton and DropdownButtonFormField. However, DropdownButtonFormField allows changing the textAlign property which we can't do in DropdownMenu.

Proposal

Expose the TextField.textAlign property to DropdownMenu. It would be a trivial change to the code, and I could submit a PR unless there is a reason that this parameter should not be exposed.
@darshankawar darshankawar added the in triage Presently being triaged by the triage team label May 9, 2024
@darshankawar
Copy link
Member

I could submit a PR unless there is a reason that this parameter should not be exposed

@angelocordero Feel free to file PR for this change. The reviewers can give feedback if this can be implemented or not.

@darshankawar darshankawar added a: text input Entering text in a text field or keyboard related problems c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: proposal A detailed proposal for a change to Flutter team-design Owned by Design Languages team and removed in triage Presently being triaged by the triage team labels May 9, 2024
@angelocordero angelocordero mentioned this issue May 9, 2024
Merged
9 tasks
@justinmc justinmc added triaged-text-input Triaged by Text Input team fyi-design For the attention of Design Languages team team-text-input Owned by Text Input team P2 Important issues not at the top of the work list and removed team-design Owned by Design Languages team labels May 9, 2024
auto-submit bot pushed a commit that referenced this issue May 30, 2024
@angelocordero
allow changing textAlign of TextField in DropdownMenu (#148074)
11cbe41 
PR for #147991
victorsanni pushed a commit to victorsanni/flutter that referenced this issue May 31, 2024
@angelocordero @victorsanni
allow changing textAlign of TextField in DropdownMenu (flutter#148074)
35355fa 
PR for flutter#147991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelocordero angelocordero

Labels
a: text input Entering text in a text field or keyboard related problems c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. fyi-design For the attention of Design Languages team P2 Important issues not at the top of the work list team-text-input Owned by Text Input team triaged-text-input Triaged by Text Input team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinmc @darshankawar @angelocordero