Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all flutter/engine macOS tests using Xcode 16 and iOS 18 simulator #148906

Open
2 tasks
Tracked by #148870 ...
vashworth opened this issue May 22, 2024 · 0 comments
Open
2 tasks
Tracked by #148870 ...

Run all flutter/engine macOS tests using Xcode 16 and iOS 18 simulator #148906

vashworth opened this issue May 22, 2024 · 0 comments
Labels
P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@vashworth
Copy link
Contributor

vashworth commented May 22, 2024

Prerequisites

Instructions

Make a PR that changes the .ci.yaml to use the new Xcode build version and run exclusively on macOS 14. Note that not all tests run in presubmit, so you'll likely need to do some of them via led or edit the .ci.yaml to run the tests in presubmit.

https://github.com/flutter/engine/blob/main/.ci.yaml

$flutter/osx_sdk : >-
        {
-          "sdk_version": "15a240d"
+          "sdk_version": "[insert new CIPD case-sensitive Xcode build version]"
        }
        
- os: Mac-13|Mac-14
+ os: Mac-14

https://github.com/flutter/engine/blob/main/ci/builders/local_engine.json
https://github.com/flutter/engine/blob/main/ci/builders/mac_android_aot_engine.json
https://github.com/flutter/engine/blob/main/ci/builders/mac_host_engine.json
https://github.com/flutter/engine/blob/main/ci/builders/mac_ios_engine.json
https://github.com/flutter/engine/blob/main/ci/builders/mac_unopt_debug_no_rbe.json

$flutter/osx_sdk : >-
        {
-          "sdk_version": "15a240d"
+          "sdk_version": "[insert new CIPD case-sensitive Xcode build version]"
        }
        
- os=Mac-13|Mac-14
+ os=Mac-14

https://github.com/flutter/engine/blob/main/ci/builders/mac_unopt.json

$flutter/osx_sdk : >-
        {
          "runtime_versions": [
-               "ios-17-0_15a240d"
+               "ios-18-0_[insert new CIPD case-sensitive Xcode build version]"
          ],
-          "sdk_version": "15a240d"
+          "sdk_version": "[insert new CIPD case-sensitive Xcode build version]"
        }
        
- os=Mac-13|Mac-14
+ os=Mac-14

https://github.com/flutter/engine/blob/main/testing/scenario_app/run_ios_tests.sh

- readonly OS_RUNTIME=com.apple.CoreSimulator.SimRuntime.iOS-17-0
- readonly OS="17.0"
+ readonly OS_RUNTIME=com.apple.CoreSimulator.SimRuntime.iOS-18-0
+ readonly OS="18.0"

In addition, golden files will need to be updated. See flutter/engine#49833 as example

File issues for tests that fail and add links to the issues in #148898. This is important so we can track any fixes that need to be cherrypicked to beta/stable and so steps that are steps are not completed before issues are resolved.

@vashworth vashworth added P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Development

No branches or pull requests

1 participant