-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to Xcode 15 and iOS 17 simulator #49833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
23 tasks
jmagman
reviewed
Jan 17, 2024
testing/scenario_app/ios/Scenarios/Scenarios.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
jmagman
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vashworth
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Jan 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
…141785) flutter/engine@b75d6d8...d80fe1c 2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/engine#49833) 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 7b3d788ba978 to b1611add5939 (1 revision) (flutter/engine#49863) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine part of flutter/flutter#132237.
Also, fixes flutter/flutter#125227.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.