Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tool] ErrorHandlingFileSystem::systemTempDirectory does not return an ErrorHandlingDirectory #150730

Closed
andrewkolos opened this issue Jun 24, 2024 · 2 comments · Fixed by #150876
Closed

[tool] ErrorHandlingFileSystem::systemTempDirectory does not return an ErrorHandlingDirectory #150730

andrewkolos opened this issue Jun 24, 2024 · 2 comments · Fixed by #150876
Assignees
@andrewkolos
Labels
P1 High-priority issues at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@andrewkolos
Copy link
Contributor

See title. ErrorHandlingFileSystem doesn't override FileSystem::systemTempDirectory. This means that any tool code utilizing FileSystem::systemTempDirectory doesn't benefit from the error-handling provided by ErrorHandlingDirectory. It is possible that this is resulting in noisy, inactionable tool crashes from file system exceptions caused by things such as permissions issues.
@andrewkolos andrewkolos added tool Affects the "flutter" command-line tool. See also t: labels. P1 High-priority issues at the top of the work list team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team labels Jun 24, 2024
@andrewkolos andrewkolos self-assigned this Jun 24, 2024
@andrewkolos
Copy link
Contributor Author

andrewkolos commented Jun 26, 2024 •
edited
Loading

I don't know if this is something that users encounter (and I'm not going to spend time figuring out how to query this, but I really hope that most users have read/write permissions to their system's temp directory).

At the very least, however, this has bit me when writing tests that 1) use systemTempDirectory and 2) use a fake/memory file system with a custom opHandle that throws an exception.

@andrewkolos andrewkolos mentioned this issue Jun 26, 2024
Merged
9 tasks
auto-submit bot pushed a commit that referenced this issue Jun 27, 2024
@andrewkolos
[tool] make the systemTempDirectory getter on `ErrorHandlingFileSys…
1f672c2 
…tem` wrap the underlying filesystem's temp directory in a`ErrorHandlingDirectory` (#150876)

Fixes #150730

If you can think of a more concise title, be my guest.
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this issue Jun 27, 2024
@andrewkolos
[tool] make the systemTempDirectory getter on `ErrorHandlingFileSys…
42c7b9a 
…tem` wrap the underlying filesystem's temp directory in a`ErrorHandlingDirectory` (flutter#150876)

Fixes flutter#150730

If you can think of a more concise title, be my guest.
@andrewkolos andrewkolos mentioned this issue Jun 28, 2024
Open
5 tasks
victorsanni pushed a commit to victorsanni/flutter that referenced this issue Jul 8, 2024
@andrewkolos @victorsanni
[tool] make the systemTempDirectory getter on `ErrorHandlingFileSys…
8ad5e87 
…tem` wrap the underlying filesystem's temp directory in a`ErrorHandlingDirectory` (flutter#150876)

Fixes flutter#150730

If you can think of a more concise title, be my guest.
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewkolos andrewkolos

Labels
P1 High-priority issues at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
None yet
Milestone
No milestone
1 participant
@andrewkolos