flutter analyze in website build script failing (after something changed in flutter engine or sdk?)
#15293
Comments
|
Switching flutter to the beta channel works fine, I'm going to jump through flutter checkouts to try and pin the exact version that broke. |
|
Check out |
|
No great surprise it was an engine roll:. Diffs are here: flutter/engine@a00f8e8...24cf8eb Those diffs also include an SDK roll from ee15c8eb689791f6777eb3f6b0a1e9c58ff0671b to b5b8080b2cfb1e4943a19787ee96548a4a604f7b. Diffs are here: dart-lang/sdk@ee15c8e...b5b8080 So, something in one of the changesets from those two compares likely broke it ;-) Bisecting across those reports might be more tricky! |
DanTup
changed the title
flutter analyze in website build script failing after something changed in flutterflutter analyze in website build script failing (after something changed in flutter engine or sdk?)
|
I'm going to change flutter/website to use beta channel (for now, at least) |
filiph
added a commit
to filiph/website
that referenced
this issue
Mar 8, 2018
This works around flutter/flutter#15293 and flutter/flutter#15301.
filiph
added a commit
to flutter/website
that referenced
this issue
Mar 8, 2018
This works around flutter/flutter#15293 and flutter/flutter#15301.
|
This is done now: flutter/website#872 |
|
This is broken again, presumably because beta has now updated to the version that causes this failure. |
This was referenced Mar 28, 2018
ZhangQinglian
added a commit
to flutter-dev/website
that referenced
this issue
Apr 12, 2018
* Fix typo in index.md. (flutter#860) * Update flutter-for-react-native.md (flutter#859) * Fix typo (flutter#861) * Update flutter-for-react-native.md (flutter#865) This sentence read: 'In order to make Row' and then proceeded to show how to arrange things in a column. * Fix some more typos (flutter#862) * Update MaterialApp ctor argument mentioned in debugging.md (flutter#863) Previously `debugging.md` mentioned `debugShowGrid` as an argument for `MaterialApp`'s constructor. I believe this came from the `stocks` example as `MaterialApp` has `debugShowMateralGrid` not `debugShowGrid`. * Clarify which devices we do not support (flutter#856) Fixes flutter/flutter#14437 * Update docs.md * Use the more stable beta channel for analysis (flutter#872) This works around flutter/flutter#15293 and flutter/flutter#15301. * Fix a typo in the class description (flutter#876) * Cookbook part4 (flutter#869) * More Recipes for the cookbook on Images, Lists, and Gesture Handling. * Fix Horizontal List complete example * Fix Typo in Long Lists recipe * Next few recipes * Fix indent (flutter#864) * Allow linking directly to specific tool and persist across site (flutter#831) * Allow selection of tab from hash in url * Add selected tool to url during tab changes * Persist selected tool in localStorage to follow around site * Use replaceState to avoid causing history entries if you flip back and forth. Fixes flutter/flutter#14888. * Fixes the explin (flutter#875) * Add hyphens to links in post content (flutter#873) This avoids extending width of post content if links have long words. * Update using-packages.md (flutter#867) * Update using-packages.md Adding word "Or" to clarify running packages get command can be done from IntelliJ or from Terminal * Add a forced newline * Align bridging sidebar titles, and shorten to fit on one line (flutter#855) * Align bridging sidebar titles, and shorten to fit on one line * Align Web devs page title with Android and React native ones * using typo (flutter#879) * Fix typo (flutter#881) * Fixed spelling error in getting-started (flutter#878) * Delete a box design of sentence (flutter#882) A sentence of "... at the following link ..." of "Problems?" of Step 6, it is only surrounded a box design (by div, pre, and code tags). Other steps, it is a normal design sentence. * Fixes the clipping issue on Safari for Flutter for RN section. (flutter#886) * Adds a Flutter for RN md file and a sidebar link * Image link and style fixes * Flutter get-started link updated * Hello world text and preview fixes along with other minor fixes * Hello world code and preview fixes along with other minor fixes * Deletes junk flutter for rn files * Update flutter-for-react-native.md * Fixes the clipping issue on mobile browsers * Add cookbook image demos, fix dismissable link (flutter#880) * Add cookbook image demos, fix dismissable link * Change Dismissable to Dismissible * Jank no more doc (flutter#870) * Stashing * Stashed. * A new version of the jank page. (In process) * New screenshots, and less text about Observatory. * Incorporating Chinmay's feedback. * Tweaking * Tweaking, changing title. * Incorporating feedback. * Tweaking * Tool UI (pics) changed, and incorporating feedback. * Fixing alt text on images. * Incorporating Devon's feedback. * Adding a link to the new performance profiling page. * Incorporating Wm's feedback. * Adding more feedback, and placing the doc in the sidenav. * tweak to the new performance article (flutter#888) * Remove space breaking a markdown link. (flutter#887) The extra space character prevents the link from being clickable. * typo fixes (flutter#890) * Add a few more recipes and two migrations (flutter#884) * [Cookbook] Reading, writing data to key-value (shared preferences) (flutter#877) * Adde key-value section to flutter cookbook * Fixed spelling errors, grammar. Added better example * Fixed grammar, changed you and your to we and our * Fixed text and grammar. * Added 'the' to few places. * Update main.dart (flutter#885) Update to coincide with Update index.md flutter#883 - Added the textDirection property to reflect the API change for text RTL support for text widgets that are not a descendant of MaterialApp. * Update index.md (flutter#883) Added the textDirection property to reflect the API change for text RTL support for text widgets that are not a descendant of MaterialApp. * remove references to deprecated createHttpClient method (flutter#893) * Fix constructor name of `MyStatefulWidget` (flutter#898) * Add missing parameter (flutter#891) * Clarify why Android Studio is needed (flutter#900) * update (flutter#892) * Add new SDK archive page (flutter#901) * Add new SDK archive page * Fix typos * Update tabs to support different types/names This restricts the tab changing to a container but also makes the prefix/storage name dynamic so we don't have to call non-editor tabs editors (eg. OSes). * Add a table of releases to sdk-archive page * Show a failure message when loading fails * Move Master inside tabs * Fix page jumping to top when showing all * Change "Mac OS" to "macOS" The rest of the site is already using macOS. * Don't request archives when we're not rendering them * Remove conversion/sort code No longer required since source data format matches what we converted to. * A few minor typos (flutter#894) * Add cupertino picker to widget catalog (flutter#903) * Replace heart with tile in getting-started (flutter#904) * Add new recipes for fonts, animations, and drawers (flutter#896) * Fix Build (flutter#916) * Make Windows requirments more specific (flutter#917) * Added example to show RESTful JSON POST (flutter#839) * De dupe ide steps (flutter#899) * Remove redundant IDE steps * Remove unused file * Remove one more mentioning of IDE steps * Fix typo (flutter#919) * Update index.md (flutter#914) Delete </aside> closing tag that was left. * Update index.md (flutter#910) Fix duplicate "the the". * Fix website build (flutter#922) * Fix links in "File issue" links page.path is the filename from the repo, page.url is the url of the resulting page. Fixes flutter/flutter#15349. * Update index.md (flutter#924) * Update index.md * Update index.md * Update iOS setup (flutter#918) Reflect Xcode 9.0 requirement given by flutter doctor * Fix networking example (flutter#921) * Update fetch-data.md Rename `json` variable to `_json` * Rename _json to responseJson * Add VS Code to Using-IDE page (flutter#906) * Add tabs and empty VS Code page This is on its own page so it can have a toc (our current kramdown tov plugin appears to not support multiple within one page). * Fix bad IDs for tabs * Support href-based tabs If a tab has a data-tab-href then navigate to it. If no tab is found, bail out and don't hide content (this allows us to skip all the storage/hash fragments for href-based tabs). * Commit all Android Studio content in VS Code page To make it easier to review the changes made, if required. * First cut at VS Code IDE page * Remove ID that link checker doesn't like This does work, but the checker can't verify it :( * Tweaks based on @devoncarew's feedback * Tweaks from review plus fix for rebasing over latest tab changes that require a container around them. * site bar -> Side Bar * Add link to #vscode Also change exclusion in rakefile to be a regex, seems like "#" was being compared as an exact string. * Link "command palette" to VS Code docs * Add docs on sharing assets with the platform * Remove developer.apple.com links from link checking (flutter#928) * Remove developer.apple.com links from link checking To work around flutter/flutter#16268 * Commas for the win * Change installation to use bundles (flutter#912) Change Flutter installation to use pre-built installation packages that can simply be extracted for installation. * Revert previous update of asset section. * Fix Apple.com links (flutter#931) * Add docs on sharing assets with the platform (flutter#929) * Improve the Views section of flutter-for-android (flutter#927) * Improve the Intents section of flutter-for-android (flutter#932) * Improve the Views section of flutter-for-android * Improve Intents section in flutter-for-android * Improve the Async UI section in flutter-for-android (flutter#933) * Improve the Project structure and Resources section in flutter-for-android (flutter#934) * Improve the Async UI section in flutter-for-android * Improve the Project section in flutter-for-android * Update version of http in sample code * adding rake to Gemfile. Rake is used to validate links as described in README's developing step 7 (flutter#930) * Fix typo (flutter#936) Fix minor typos in catalog/samples page * Updating the accessibility info. (flutter#926) * Facebook Login Package (flutter#895) Since the https://pub.dartlang.org/packages/flutter_facebook_connect is no longer maintained, updated it with https://pub.dartlang.org/packages/flutter_facebook_login * Update Learn More link to point to beta 2 post (flutter#943) * Fix code validation issue (flutter#944) Currently failing with `child' is deprecated and shouldn't be used at example/text_input_md_1.dart:31:15 • deprecated_member_use` * Make the formatter happy (flutter#945) Follow-up to flutter#944 * Cookbook: Background processing, Orientation, and Updates (flutter#920) * Update key-value recipe * Add background processing example * Add orientation recipe * Update a few stale FAQ entries (flutter#940)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The flutter/website build is broken on Travis. It looks to be broken by something external (the change that triggered the build is a single character change in the website repo). The build clones the latest
flutter/fluttermastercode and runsflutter analyzeon some code.The last working build was after this commit (to website) and analyzed fine:
Then when this commit (to website) was pushed and flutter cloned for its build, it failed with:
The text was updated successfully, but these errors were encountered: