Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing animation lagging (appears to be a regression) #15294

Closed
RobertBrunhage opened this issue Mar 8, 2018 · 6 comments
Closed

Routing animation lagging (appears to be a regression) #15294

RobertBrunhage opened this issue Mar 8, 2018 · 6 comments
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) f: routes Navigator, Router, and related APIs.

Comments

@RobertBrunhage
Copy link

RobertBrunhage commented Mar 8, 2018

I have an open StackOverFlow issue here that expains the issue that I have: https://stackoverflow.com/questions/49145258/flutter-routing-stutter?noredirect=1#comment85329917_49145258

In short: It lags when routing to a new view. Tried the flutter gallery app in play store but it doesn't lag. Ran the flutter gallery app with flutter run --released and the issue is there again.

Flutter doctor -v

[√] Flutter (Channel beta, v0.1.5, on Microsoft Windows [Version 10.0.16299.248], locale en-GB)
    • Flutter version 0.1.5 at C:\Users\Robert\flutter
    • Framework revision 3ea4d06340 (2 weeks ago), 2018-02-22 11:12:39 -0800
    • Engine revision ead227f118
    • Dart version 2.0.0-dev.28.0.flutter-0b4f01f759

[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at C:\Users\Robert\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[√] Android Studio (version 3.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[√] Connected devices (1 available)
    • ONEPLUS A3003 • 5ffff941 • android-arm64 • Android 8.0.0 (API 26)
@RobertBrunhage RobertBrunhage changed the title Routing bug Routing animation lagging (appears to be a regression) Mar 8, 2018
@Hixie Hixie added the f: routes Navigator, Router, and related APIs. label Mar 8, 2018
@Herohtar
Copy link

Herohtar commented Mar 8, 2018

You can see the difference in the Flutter Gallery apps in the Play Store.

Flutter Gallery posted by "Google Samples" with a release date of 2017-04-24, version flutter-gallery-bv8-rc000: https://play.google.com/store/apps/details?id=io.flutter.gallery

Flutter Gallery posted by "flutter.io" with a release date of 2018-02-22, version 0.1.5-pre.25: https://play.google.com/store/apps/details?id=io.flutter.demo.gallery

Animations in the 2017 one are smooth, while the 2018 version has the stuttering/lagging.

@xster xster added the c: performance Relates to speed or footprint issues (see "perf:" labels) label Mar 8, 2018
@Hixie
Copy link
Contributor

Hixie commented Mar 14, 2018

This is probably just a side-effect of us disabling the fade animation, see #13736.

@xster
Copy link
Member

xster commented Mar 15, 2018

Can you guys describe the stuttering/lag a bit more?

If the Android page transition appears and vanishes in the middle of the screen during the animation, it's a known issue #13736. If the animation motion itself is jittery or drops frames, it'd be a different issue. @Herohtar, what phone are you using?

@Herohtar
Copy link

Herohtar commented Mar 15, 2018

@xster My phone is the Pixel 2 XL.

After taking a closer look to try to get a better idea of what's going on, I think the issue I'm seeing is that when pushing a route the page just pops into existence about 2/3 of the way up, then slides the rest of the way to the top. It's a bit more noticeable going the other direction: the page slides down, then stops briefly -- again at 2/3 of the way up the screen -- then just vanishes. The animation during the sliding phase looks okay; I think the pause and then the abrupt vanishing is what gives it a sense of being stuttery/jerky/laggy for me.

I can confirm that the appear/disappear at 2/3 up the screen is indeed happening by turning on slow animations in the gallery app; it's quite obvious then. All the sliding animation is smooth in that case, but since it's moving so slowly I would expect it to be.

Is that #13736?

@xster
Copy link
Member

xster commented Mar 15, 2018

Yes. I'll close this bug as a dupe of #13736. For an immediate solution applicable locally, see the debugEnableFadingRoutes flag on MaterialPageRoute.

@xster xster closed this as completed Mar 15, 2018
@InMatrix InMatrix added this to Not much the user can do in Performance Debugging Experience Jul 13, 2018
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) f: routes Navigator, Router, and related APIs.
Projects
Performance Debugging Experience
Not much the user can do
Development

No branches or pull requests

4 participants