Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jank in dismissal Animation in Android #15116

Closed
ajaybeniwal opened this issue Mar 4, 2018 · 8 comments
Closed

Jank in dismissal Animation in Android #15116

ajaybeniwal opened this issue Mar 4, 2018 · 8 comments
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) framework flutter/packages/flutter repository. See also f: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Comments

@ajaybeniwal
Copy link

ajaybeniwal commented Mar 4, 2018 •
edited
Loading

Steps to Reproduce

I followed the sample app mentioned in the Write your first app steps , When i open the recently saved page it opens as usual but when the page is dismissed using back button it shows kind of Jank and animation does not feel smooth like native android app
@SKLn-Rad
Copy link

SKLn-Rad commented Mar 4, 2018

Glad I'm not the only one seeing this as I'm desperate to demo this as a solution to my agency.

Any update on this?

@xster
Copy link
Member

xster commented Mar 5, 2018

You may be already doing it but please remember to run it in release mode (flutter run --release) as the debug mode performance is not representative of what your users will ultimately see.

@ajaybeniwal
Copy link
Author

Even in release mode I see some jank in dismissal it does not feel as smooth as native dismissal

@Herohtar
Copy link

Herohtar commented Mar 8, 2018 •
edited
Loading

I'm seeing some bad looking behavior with my app as well, running in --release mode, not sure if it's the exact same thing... when navigating to a new page, the page appears at 2/3 of the way up the screen, then continues to animate up to the top. Reverse happens when going back, page animates down and then disappears about the 2/3 mark again. The animation is very noticeably stutter-y, more so when animating down.

This is on a Pixel 2 XL running Android 8.1.

@Herohtar
Copy link

Herohtar commented Mar 8, 2018

I think this is related to #15294

@xster xster added the c: performance Relates to speed or footprint issues (see "perf:" labels) label Mar 8, 2018
@zoechi
Copy link
Contributor

zoechi commented Dec 4, 2018

The linked issue #13736 (#15294 is marked as dup of #13736) is fixed.
Is this issue still relevant?

@zoechi zoechi added the framework flutter/packages/flutter repository. See also f: labels. label Dec 4, 2018
@zoechi zoechi added this to the Goals milestone Dec 4, 2018
@goderbauer goderbauer added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Dec 28, 2018
@zoechi
Copy link
Contributor

zoechi commented Jan 21, 2019

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

@zoechi zoechi closed this as completed Jan 21, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
bfb8f1d 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
3ba57a9 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
This was referenced Feb 3, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
f814c3b 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
88d8bec 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
c392d5b 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
649323d 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
34e7dbd 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
This was referenced Feb 3, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
86e702c 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 3, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
9a64050 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
f494afc 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
54201ab 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
e4c6a00 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
e2816a1 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
12b31ea 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
c8c2734 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
0ab6f4f 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
26f7c5a 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
0bb86dc 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
6dfc849 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
f2ade05 Revert "Modifies accessibility bridge to populate new node fi…
d964279 
…elds in semantic… (flutter#15116)" (flutter/engine#16323)
Merged
engine-flutter-autoroll added a commit that referenced this issue Feb 4, 2020
@engine-flutter-autoroll
Roll engine 0816c04..810b9b9 (21 commits) (#50083)
5039e25 
flutter/engine@0816c04...810b9b9

git log 0816c04..810b9b9 --first-parent --oneline
2020-02-03 anna_gringauze@hotmail.com supporting changes for evaluation in web debugger (flutter/engine#16309)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia f1e316ff39e7..af99f3ee6017 (13 commits) (flutter/engine#16335)
2020-02-03 chinmaygarde@google.com Update buildroot to 02b77827fd4ac639f1c048c6340262cdb4c2a3ab. (flutter/engine#16339)
2020-02-03 chinmaygarde@google.com Disable flaky MessageLoop tests on Fuchsia. (flutter/engine#16340)
2020-02-03 iska.kaushik@gmail.com [fuchsia] Add additional contributing instructions for Googlers (flutter/engine#16337)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/dart ed441e48d055..c8ed304e979a (1 commits) (flutter/engine#16328)
2020-02-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from AtXwP... to Tszo5... (flutter/engine#16334)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d05192abedf..f1e316ff39e7 (3 commits) (flutter/engine#16329)
2020-02-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jtwQF... to 6h3IH... (flutter/engine#16332)
2020-02-03 dnfield@google.com Change NSLog to FML_DLOG (flutter/engine#16331)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 5d92ae2b56df..3d05192abedf (1 commits) (flutter/engine#16326)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 776293dceefd..5d92ae2b56df (1 commits) (flutter/engine#16325)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1b80c357926b..776293dceefd (2 commits) (flutter/engine#16324)
2020-02-01 dnfield@google.com use echo to test whether host is up (flutter/engine#16322)
2020-02-01 dnfield@google.com Revert "Modifies accessibility bridge to populate new node fields in semantic… (#15116)" (flutter/engine#16323)
2020-02-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from x6sVj... to jtwQF... (flutter/engine#16320)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/dart 91a3ea89c8e4..ed441e48d055 (4 commits) (flutter/engine#16319)
2020-02-01 chinmaygarde@google.com Remove all uses of the redundant flutter_root variable. (flutter/engine#16311)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4513cdde4912..1b80c357926b (1 commits) (flutter/engine#16318)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/dart 5ae5aff6406a..91a3ea89c8e4 (22 commits) (flutter/engine#16310)
2020-01-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VMcGV... to AtXwP... (flutter/engine#16308)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) framework flutter/packages/flutter repository. See also f: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@xster @zoechi @ajaybeniwal @goderbauer @SKLn-Rad @Herohtar