Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale VERSION file inside the SDK shipped with Flutter #15348

Closed
DanTup opened this issue Mar 9, 2018 · 5 comments
Closed

Stale VERSION file inside the SDK shipped with Flutter #15348

DanTup opened this issue Mar 9, 2018 · 5 comments
Assignees
@rmacnak-google
Labels
dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels.

Comments

@DanTup
Copy link
Contributor

DanTup commented Mar 9, 2018 •
edited
Loading

Dart Code displays the contents of the VERSION file in the Dart SDK in the status bar. Sometime recently (possibly when Flutter switched to making its own SDK builds) it seems that this file became stale:

Dannys-MacBook:~ danny$ flutter --version
Flutter 0.1.6-pre.3 • channel master • https://github.com/DanTup/flutter.git
Framework • revision 7f03b9e41b (2 weeks ago) • 2018-02-23 12:49:57 -0800
Engine • revision ead227f118
Tools • Dart 2.0.0-dev.28.0.flutter-0b4f01f759
Dannys-MacBook:~ danny$ cat /Users/danny/Dev/Google/flutter/bin/cache/dart-sdk/version
2.0.0-edge.0d5cf900b021bf5c9fa593ffa12b15bcd1cc5fe0

The Dart SDK revision is 0b4f01f759 (confirmed by running dart --version) so not sure why the file is bad.

Dart Code uses this files because it's faster (and less troublesome) than spawning a process.
@aam
Copy link
Member

aam commented Mar 9, 2018

https://dart-review.googlesource.com/c/sdk/+/45921 with the potential fix.

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Mar 9, 2018
@rmacnak-google
[build] Declare dependency of the version strings on the current Git …
c080951 
…commit.

Bug: flutter/flutter#15348
Change-Id: Ifef1b55c6efe0f030ee83e4c43a774c7cd049fac
Reviewed-on: https://dart-review.googlesource.com/45921
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Mar 10, 2018
@rmacnak-google
Revert "[build] Declare dependency of the version strings on the curr…
439badf 
…ent Git commit."

This reverts commit c080951.

Reason for revert: Breaks Debian source package

Original change's description:
> [build] Declare dependency of the version strings on the current Git commit.
> 
> Bug: flutter/flutter#15348
> Change-Id: Ifef1b55c6efe0f030ee83e4c43a774c7cd049fac
> Reviewed-on: https://dart-review.googlesource.com/45921
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Alexander Aprelev <aam@google.com>

TBR=aam@google.com,rmacnak@google.com,zra@google.com,phosek@google.com

Change-Id: I16ff18213bd1592c21bd9ae99b6e97fbdfc1824c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: flutter/flutter#15348
Reviewed-on: https://dart-review.googlesource.com/45980
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@zanderso
Copy link
Member

These are different because https://github.com/dart-lang/sdk/blob/master/tools/make_version.py has different logic from https://github.com/dart-lang/sdk/blob/master/tools/write_version_file.py.

We should probably eliminate https://github.com/dart-lang/sdk/blob/master/tools/write_version_file.py, and instead use https://github.com/dart-lang/sdk/blob/master/tools/make_version.py to write the version file to make sure that they both say the same thing.

DanTup added a commit to Dart-Code/Dart-Code that referenced this issue May 8, 2018
@DanTup
Don't show Dart version in status bar for Flutter projects
25c311e 
Fixes #887.

Can be reverted once flutter/flutter#15348 is fixed.
@Hixie
Copy link
Contributor

Hixie commented Jun 8, 2018

What's the status of this issue?

@Hixie Hixie added this to the Stretch Goals milestone Jun 8, 2018
@Hixie Hixie added engine flutter/engine repository. See also e: labels. dependency: dart Dart team may need to help us labels Jun 8, 2018
@DanTup
Copy link
Contributor Author

DanTup commented Jun 9, 2018

Still an issue. This is latest master:

Dannys-MacBook:flutter danny$ flutter --version
Flutter 0.5.3-pre.18 • channel master • https://github.com/DanTup/flutter.git
Framework • revision 326caa5d22 (15 minutes ago) • 2018-06-09 03:39:27 -0400
Engine • revision 5d2f24aa5c
Tools • Dart 2.0.0-dev.60.0.flutter-a5e41681e5

Dannys-MacBook:flutter danny$ cat bin/cache/dart-sdk/version 
2.0.0-edge.c080951d45e79cd25df98036c4be835b284a269c

a5e41681e5 is the correct version, which is from 4 days ago.
c080951d45 is wrong, it's a commit from March.

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jun 11, 2018
@rmacnak-google
[build] Declare dependency of the version strings on the current Git …
86db781 
…commit.

Add fake Git reflog to Debian source tarball.

Bug: flutter/flutter#15348
Bug: #32614
Change-Id: Ib4104a98cf245ee11285a37d5eee3165ca656645
Reviewed-on: https://dart-review.googlesource.com/48091
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@DanTup DanTup mentioned this issue Jul 24, 2018
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rmacnak-google rmacnak-google

Labels
dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aam @Hixie @DanTup @zanderso @rmacnak-google