Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto assist for the map literal creation for routes #16206

Closed
branflake2267 opened this issue Apr 4, 2018 · 3 comments
Closed

Add auto assist for the map literal creation for routes #16206

branflake2267 opened this issue Apr 4, 2018 · 3 comments
Labels
dependency: dart Dart team may need to help us

Comments

@branflake2267
Copy link

I'd like to suggest adding auto assist completion for the map literal with types for the Scaffold routes argument. Something like the children literal array is created for ListView could be useful.

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return new MaterialApp(
      title: 'Flutter Demo',
      theme: new ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: new MyHomePage(),
      // ~~~ auto assist could create this...
      routes: <String, WidgetBuilder>{
         // insert caret
      },
    );
  }
}

screen shot 2018-04-03 at 7 35 34 pm

Steps to Reproduce

  1. add the routes: property for scaffold
  2. key in control + space to try to auto assist completion

Logs

Nothing useful.

Flutter Doctor

brandons-mbp:flutter_preferences branflake2267$ flutter doctor -v
[✓] Flutter (Channel master, v0.2.9-pre.17, on Mac OS X 10.13.3 17D102, locale en-US)
    • Flutter version 0.2.9-pre.17 at /Users/branflake2267/git/flutter
    • Framework revision 7a6a65a597 (12 minutes ago), 2018-04-03 19:31:08 -0700
    • Engine revision 04f3c6557c
    • Dart version 2.0.0-dev.43.0.flutter-52afcba357

[!] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/branflake2267/Library/Android/sdk
    • Android NDK at /Users/branflake2267/Library/Android/sdk/ndk-bundle
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    ✗ Android license status unknown.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.3, Build version 9E145
    • ios-deploy 1.9.2
    • CocoaPods version 1.4.0

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 23.1.3
    • Dart plugin version 181.4203.498

[✓] IntelliJ IDEA Community Edition (version 2017.3.5)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 22.2.2
    • Dart plugin version 173.4700

[✓] VS Code (version 1.21.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Dart Code extension version 2.11.1

[!] Connected devices
    ! No devices available

! Doctor found issues in 2 categories.
@zoechi
Copy link
Contributor

zoechi commented Jul 6, 2018

@devoncarew do you think this can be done.
Should this issue be moved to dart-lang/sdk to get the attention of the analyzer team?

@zoechi
Copy link
Contributor

zoechi commented Dec 7, 2018

Issue moved to flutter/flutter-intellij #2929 via ZenHub

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Jan 31, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Jan 31, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Jan 31, 2020
engine-flutter-autoroll added a commit that referenced this issue Jan 31, 2020
flutter/engine@74d07b5...804dca6

git log 74d07b5..804dca6 --first-parent --oneline
2020-01-31 yjbanov@google.com Use bundled Roboto in all tests (flutter/engine#16218)
2020-01-31 gw280@google.com Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (#15118)" (flutter/engine#16277)
2020-01-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia 36c0521d57de..6305b2f8342a (8 commits) (flutter/engine#16272)
2020-01-31 jason-simmons@users.noreply.github.com Revert "[web] Correct getPositionForOffset for multi-line paragraphs (#16206)" (flutter/engine#16268)
2020-01-30 stuartmorgan@google.com Fix Windows file checks of unicode paths (flutter/engine#16105)
2020-01-30 iska.kaushik@gmail.com [fuchsia] Fix the import for dart_api.h (flutter/engine#16269)
2020-01-30 iska.kaushik@gmail.com [fuchsia] SceneHostBindings are no longer thread locals (flutter/engine#16262)
2020-01-30 gw280@google.com Pass through invoker.resources in fuchsia_test_archive (flutter/engine#16265)
2020-01-30 matthew-carroll@users.noreply.github.com Notify PlatformViewsController within FlutterEngine when a hot restart occurs. (#48518) (flutter/engine#16230)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/dart fc3af737c759..162d6c5634a0 (209 commits) (flutter/engine#16261)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia d1be5d64f8a7..36c0521d57de (13 commits) (flutter/engine#16260)
2020-01-30 mouad.debbar@gmail.com [web] Correct getPositionForOffset for multi-line paragraphs (flutter/engine#16206)
2020-01-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from -mGIA... to 93K0d... (flutter/engine#16257)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 6, 2020
dnfield pushed a commit that referenced this issue Feb 7, 2020
* d5442b8 Roll src/third_party/skia bc3307c395e2..ebc00f97fab1 (21 commits) (flutter/engine#16429)

* 76b291a Added a plugin method that gets called when the engine is about to be deleted (flutter/engine#16336)

* 07f25c5 fix bad reference to maxDiffRatePercent (flutter/engine#16440)

* 41d50c2 Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (flutter/engine#16365)

* f25d325 [fuchsia] change kMaxFramesInFlight to 3 (flutter/engine#16425)

* 473f559 Suppress some deprecation warnings on Windows (flutter/engine#16416)

* 2e34ad6 Roll fuchsia/sdk/core/mac-amd64 from ubThi... to fvWgE... (flutter/engine#16454)

* 47c02e6 Roll src/third_party/skia ebc00f97fab1..cbf79b95c2d4 (4 commits) (flutter/engine#16456)

* 3d1b112 Roll buildroot (flutter/engine#16419)

* 28e6637 Add explicit casts to printing of function pointers (flutter/engine#16370)

* 9ad81da Wrap strdup to use compliant name on Windows (flutter/engine#16372)

* 9708e52 Roll rapidjson (flutter/engine#16347)

* f06ebba Include <memory> in hb_wrapper.h because unique_ptr is used. (flutter/engine#16442)

* e530376 Roll fuchsia/sdk/core/linux-amd64 from VJv0H... to A9STP... (flutter/engine#16457)

* 4cc41ae Roll src/third_party/skia cbf79b95c2d4..4721e067812f (1 commits) (flutter/engine#16459)

* 2f233ed Roll src/third_party/skia 4721e067812f..f6e3eaf05150 (1 commits) (flutter/engine#16461)

* b0b0ed8 Roll src/third_party/skia f6e3eaf05150..cc21d0c1f2ce (1 commits) (flutter/engine#16463)

* 7fea936 Roll src/third_party/skia cc21d0c1f2ce..116b33e8ab21 (3 commits) (flutter/engine#16466)

* 001b3a0 Roll src/third_party/skia 116b33e8ab21..7f36405ea3ec (3 commits) (flutter/engine#16471)

* f3ce90e Reset width/height before deallocation for Safari allocation bug. (flutter/engine#16469)
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependency: dart Dart team may need to help us
Projects
None yet
Development

No branches or pull requests

2 participants