Flutter crashes within the DartVM on certain eval calls #18573
Comments
|
I'm running flutter gallery in IJ with flutter from master: Starting the app and clicking on different elements in |
|
Select the widget on the device instead of in the tree view. |
|
Hi, is there an update on this issue? It is blocking a roll of Flutter into g3. |
|
The fix has landed flutter engine. I'm verifying that the bug is fixed now. |
|
The issue is believed to be fixed with dart roll that landed in flutter/engine#5559. The next step is to roll engine into flutter, which is pending on previous engine roll into flutter to be completed(#18575 - it has landed, but it's not clear whether it will stick). |
|
This fix appears to be rolled in at fb8cbf2. Can we close this issue yet? |
|
Not yet. I still see exceptions with the fix. |
|
It is believed that |
|
@jacob314 Any updates? This is blocking all our rolls. |
|
@Hixie wrote
In #18657 we landed a workaround for this issue until dart roll with the fix lands. Dart roll has not landed yet since there was dart roll freeze until today, it's work in progress right now(flutter/engine#5610 landed dart sdk into engine, #19044 will land that engine into flutter). |
|
Any update on when the full fix lands? The workaround isn't enough. |
|
What are the issues you are seeing with the workaround? |
|
@aam fwiw, this has been open so long now that we don't have any candidates for this beta cycle. In retrospect, we really should have reverted. |
|
Adding the crashers seen on June 28th from the chat thread. I still see some crashes evaluating expressions when paused at breakpoints. I can't repro the exceptions with the engine roll attempt so I wouldn't spend time investigating them. Some examples: Patching in the new engine roll things are better although it does appear users will have a bad time unless the know to manually delete their build directory. Without deleting the build directory I get this crasher on IOS: |
Ah, right, we need fix for dart-lang/sdk#33087 that landed on Jun 29.
Well, who could have predicted we would be blocked from rolling framework forward for over two weeks. |
|
Can this issue be closed or at least the TODAY label removed as we have completed the roll of Dart into flutter and there are no known open issues with the expression evaluation code. |
|
Checked with Jacob and he confirmed that crashes from eval expression were resolved with the latest Dart roll, the only issue remaining is the issue of exceptions resulting in engine crashes which is being tracked in #19354 |
|
I am getting this error while trying to parse json responses to dart object. I have no idea what is causing this problem. Google search landed me here. Following is the stack trace |
|
@vipinagrahari please create a new issue with properly filled issue template. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Steps to Reproduce
I'll work on simpler repro steps that don't require IntelliJ or the widget inspector but filing this now to get started.
Open the Widget inspector in IntelliJ.
Inspect a widget on the device.
This triggers IntelliJ to send an eval call to the DartVM that has a name in scope. This in turn crashes the Flutter VM. The issue reproduces with a trivial flutter app (e.g. the getting started default app) or with the gallery app.
Logs
The crash looks like
The text was updated successfully, but these errors were encountered: