New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM Service extensions crash the Flutter VM #19354
Comments
I tried this on beta(c7ea3ca), it exhibits same behavior. So this is not recent regression. |
The RPC exception above is really bringing just flutter tools down. The reason for that is that flutter tools doesn't handle exceptions thrown by RPC call. Wrapping _debugToggleDebugPaintSizeEnabled in flutter_tools/lib/src/resident_runner.dart with |
Who should own this issue? |
I'm happy to add exception handling, it would be nice to confirm impact on Jacob's work first to understand why this became a problem now. Meanwhile, removing 'TODAY' tag as this doesn't look like a recent regression. |
Not sure what is different on our setups but this definitely crashes on my laptop. The crash is not purely in Flutter tools. I am using an android emulator to repro. Here is a repro of it not crashing at all on an older build. If you merge to include the latest engine roll it will crash the dart vm when running in an android emulator. |
Does it crash the same way when you run on physical device?
|
On emulator I get the same exception as I do on physical device |
My macbook pro has started crashing in general so let me make sure I can repro the physical device crashes on my linux machine as well. I'll update when I have instructions that expose a C++ crash not just a flutter_tool crash. |
Ok so the problem is the C++ crash only reproduces using IntelliJ to communicate with Flutter instead of using Flutter Tool directly. The difference is probably that when using flutter tool, you are not waiting for uncaught exceptions so the code paths that cause the exception are not triggered. Here is the crash from IntelliJ using tip of trunk with the engine roll.
I'm not sure why service methods are being invoked differently in this case. |
Update is the latest engine roll should fix the issue. I will close as soon as it lands. Likely this is a duplicate of the other breakpoint related bug. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Steps to Reproduce
Modify any ext.flutter. service extension to throw an exception
For example modify the debugPaint service extension as follows:
Trigger the service extension either from flutter tool or from intellij.
From flutter tool, press 'p' to trigger this extension.
From intellij you just get a crash in C++ code. With flutter tool you get a bit more information.
Example
The text was updated successfully, but these errors were encountered: