Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace missed_frame_rasterizer_budget_count with 90th and 99th percentile rasterizer time #18727

Closed
goderbauer opened this issue Jun 22, 2018 · 4 comments · Fixed by #18930
Closed
Assignees
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@goderbauer
Copy link
Member

65069ed seems to have regressed the flutter_gallery__transition_perf/missed_frame_rasterizer_budget_count benchmark. It did improve the flutter_gallery__transition_perf/average_frame_rasterizer_time_millis benchmark though.

/cc @liyuqian

@goderbauer goderbauer added c: regression It was better in the past than it is now c: performance Relates to speed or footprint issues (see "perf:" labels) ⚠ TODAY labels Jun 22, 2018
@liyuqian
Copy link
Contributor

This should be the same as #13736 (comment)

To avoid future confusion, I strongly recommend to track 90% percentile and 99% percentile frame time instead of number of missed frames on our benchmark dashboard. That's what Android does.

@Hixie @yjbanov

@liyuqian liyuqian added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. and removed c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now ⚠ TODAY labels Jun 22, 2018
@goderbauer
Copy link
Member Author

If these new values are the new expected once, can you rebase the benchmarks so they don't appear actionable anymore?

@liyuqian
Copy link
Contributor

liyuqian commented Jun 22, 2018 via email

@liyuqian liyuqian self-assigned this Jun 25, 2018
@liyuqian liyuqian changed the title Benchmark Regression Replace missed_frame_rasterizer_budget_count with 90th and 99th percentile rasterizer time Jun 27, 2018
liyuqian added a commit to liyuqian/flutter that referenced this issue Jun 27, 2018
liyuqian added a commit that referenced this issue Jun 28, 2018
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants