Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in Video_player for Android from 0.5.4 to 0.6.1 breaks a functionality of my app on a few phones #18749

Closed
Jasonthefirst opened this issue Jun 23, 2018 · 12 comments
Labels
c: regression It was better in the past than it is now p: video_player The Video Player plugin package flutter/packages repository. See also p: labels.

Comments

@Jasonthefirst
Copy link

Jasonthefirst commented Jun 23, 2018

Hi,

I use the video_player plugin for an app for physical education teachers. In the App teachers can scroll through gymnastic videos and see how their students should execute a physical exercise. To see the differences they are able to scroll frame by frame through the videos. This worked really well until 0.5.4 changed to 0.6.0 and the player for android changed from media player to exo player. I can't seek fast from frame to frame on some devices. It seems like the player only seeks to a few frames but not every single frame. This happens for example on a nexus 7 2013 but not in the local emulator.

My app opens local files and streams online files if the local file is not yet loaded as well.

The app opens the file:

    videoController = new VideoPlayerController.file(videoFile);
    videoController.addListener(listener);

    videoController.setVolume(0.0);
    videoController.setLooping(true);

    videoController.initialize();
    videoController.play();

And while using a Slider the videoController seeks to a corresponding position in the video:

    videoController.pause();

    Duration seekpos = new Duration(
    minutes: minutes, seconds: seconds, milliseconds: msseconds);
    videoController.seekTo(seekpos);

In the emulator it is working as before but on the Nexus 7 it is juddering a lot.

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel dev, v0.5.5, on Microsoft Windows [Version 10.0.17134.112], locale de-DE)
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[√] Android Studio (version 3.1)
[√] IntelliJ IDEA Ultimate Edition (version 2018.1)
[√] Connected devices (3 available)

• No issues found!

Edit:
The videos are encoded with H264 mp4 with a forced keyint of 1 for smooth scrolling.

@zoechi zoechi added c: regression It was better in the past than it is now plugin labels Jun 25, 2018
@zoechi
Copy link
Contributor

zoechi commented Jun 26, 2018

flutter/plugins#622 looks like it could fix that

@cbenhagen
Copy link
Contributor

Unfortunately not. Frame accurate seek is the default on ExoPlayer. flutter/plugins#622 only adds the same behaviour to the iOS where the default would otherwise be to seek to the next key frame.

@Jasonthefirst
Copy link
Author

Generally I have a problem, that BOTH versions (mediaplayer and exoplayer) don't play on some Samsung devices (S7 especially). The video starts but only skips between the first two frames. Should I open another Issue or is this related?

@Jasonthefirst
Copy link
Author

Tried the new update (0.6.4) and it seems a little bit better but only if I slow and wait on a position for a while. I use a slider to seek to a position in the video and with 0.5.4 it works like a charm. But with 0.6.0 and 0.6.4 I can go to the position with the slider and have to wait for a few seconds to resume sliding.

@zoechi zoechi added the p: video_player The Video Player plugin label Jan 8, 2019
@collinjackson
Copy link
Contributor

Here's the commit that switched over to Exoplayer. flutter/plugins@eb17154 in June 2018.

@collinjackson
Copy link
Contributor

It's not clear to me what the solution is here but patches are welcome. We don't currently have an active maintainer for this plugin who can help at this time.

@Jasonthefirst feel free to open a new issue for the Samsung device issue.

@iskakaushik
Copy link
Contributor

Hey @Jasonthefirst are you still having problems with the video player plugin? Seems like there is an issue with seeking to a position, are you able to see it on the latest version?

@iskakaushik iskakaushik self-assigned this Apr 25, 2019
@iskakaushik iskakaushik added this to the Goals milestone Apr 25, 2019
@iskakaushik iskakaushik added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 25, 2019
@no-response
Copy link

no-response bot commented May 16, 2019

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

@no-response no-response bot closed this as completed May 16, 2019
@Jasonthefirst
Copy link
Author

I am really sorry it took me so long to response.
Sadly I still have this problem with the video_player plugin. I still have to use version 0.5.4 because I can't use frame to frame seeking with everything newer. As soon as I switch to the most recent plugin version (0.10.5+2) I can't scroll smoothly through the video.
As soon as I move the slider a little bit faster the video won't update its frame until I stop moving the slider or move it really slow.

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jan 18, 2020
@no-response no-response bot reopened this Jan 18, 2020
@TahaTesser
Copy link
Member

Hi @Jasonthefirst
Could you create a new issue for problems you are facing latest version of video_player in detail and explain the reason why you still need to use older version?
Thank you

@TahaTesser TahaTesser added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Mar 17, 2020
@iskakaushik iskakaushik removed their assignment Mar 17, 2020
@iapicca
Copy link
Contributor

iapicca commented Apr 22, 2020

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v' please.
All system setups can be slightly different so it's always better to open new issues and reference related issues.

@iapicca iapicca closed this as completed Apr 22, 2020
@lock
Copy link

lock bot commented May 6, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock bot locked and limited conversation to collaborators May 6, 2020
@pedromassangocode pedromassangocode removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label May 14, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: regression It was better in the past than it is now p: video_player The Video Player plugin package flutter/packages repository. See also p: labels.
Projects
None yet
Development

No branches or pull requests

8 participants