Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

video_player: frame accurate seekTo on iOS #622

Merged
merged 2 commits into from
Jun 26, 2018

Conversation

cbenhagen
Copy link
Contributor

Same behaviour as on android. A keyframe accurate seekTo method could be introduced for both platforms to enhance performance at the cost of accuracy.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@cbenhagen
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please add pubspec.yaml version bump and CHANGELOG.md entry.

@cbenhagen
Copy link
Contributor Author

@mravn-google done ;)

@mravn-google
Copy link
Contributor

This branch seems to need a rebase now. Sorry.

Same behaviour as on android. A keyframe accurate seekTo method could be introduced for both platforms to enhance performance at the cost of accuracy.
@cbenhagen
Copy link
Contributor Author

No worries. Branch has been rebased.

@cbenhagen
Copy link
Contributor Author

Do you prefer the commits to be squashed when we are at it?

@mravn-google
Copy link
Contributor

Thanks. I'll squash them as I merge.

Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mravn-google mravn-google merged commit bf077e9 into flutter:master Jun 26, 2018
@cbenhagen cbenhagen deleted the patch-1 branch June 26, 2018 12:27
najeira added a commit to najeira/flutter-video-player that referenced this pull request Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants