Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment_references lint doesn't support dartdoc's idea of "in scope" #20765

Closed
Hixie opened this issue Aug 18, 2018 · 4 comments
Closed

comment_references lint doesn't support dartdoc's idea of "in scope" #20765

Hixie opened this issue Aug 18, 2018 · 4 comments

Comments

@Hixie
Copy link
Contributor

Hixie commented Aug 18, 2018

As of dart-lang/dartdoc#1153, dartdoc considers pretty much everything it knows about to be in scope regardless of whether it's in scope at the Dart level. Unfortunately, the comment_references lint doesn't follow the same convention. So, for example, packages/flutter/lib/painting.dart in flutter's repo ends up flagging the three terms in the library docs ([TextPainter], [Decoration], etc) even though those are valid. This makes the lint unusable for our purposes, even though it actually catches a bunch of errors so we would love to use it.

@zoechi
Copy link
Contributor

zoechi commented Aug 20, 2018

the comment_references lint doesn't follow the same convention

Don't you think it should?

Do you plan to file an issue in https://github.com/dart-lang/linter/issues?

@Hixie
Copy link
Contributor Author

Hixie commented Aug 21, 2018

Wow I totally filed that in the wrong repo, my bad.

@Hixie
Copy link
Contributor Author

Hixie commented Aug 21, 2018

dart-lang/linter#1142

@Hixie Hixie closed this as completed Aug 21, 2018
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants