Picture.toImage breaks backwards compatibility

[lukef]

On master, Picture.toImage in dart:ui now returns a Future (so is async) where it used to be sync. This creates an issue with libraries that use this call (like https://github.com/lukef/qr.flutter).

I'm going to assume that there are going to be some assurances around backwards compatibility moving forward? If not, we will need a way to isolate platform version specific code so that developers (like me) don't have to maintain a bunch of different library versions whenever the underlying platform changes.

For now, I can bump the version and direct developers to use a lower version for 1.0 and a higher version for master (and beyond) however, should we trust that decisions like this one that are made (and pushed) to master are going to be in constant flux? i.e: tell developers to not use master?

Also, there is no mechanism to peg the library to specific Flutter versions (right?). So it's still highly possible that developers will use the wrong version regardless.

[GaryQian]

cc @jason-simmons

[zoechi]

As far as I know this was to fix #23621 by #7442 to make Picture.toImage work.

[lukef]

I have to assume that this fix wont be rolled back at this point?

[jason-simmons]

This is an intentional change to the API. Fixing #23621 required making this method asynchronous

[zoechi]

decisions like this one that are made (and pushed) to master are going to be in constant flux?

From what I have seen the Flutter team avoids any breaking change, but in this case it was necessary to make a broken feature work.

I don't think there is anything actionable left and therefore closing.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.