Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUCI] We should test packaging on master without uploading #28618

Closed
dnfield opened this issue Feb 28, 2019 · 7 comments
Closed

[LUCI] We should test packaging on master without uploading #28618

dnfield opened this issue Feb 28, 2019 · 7 comments
Assignees
@godofredoc
Labels
a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team team-release Owned by Release team
Projects
Better Flutter Releases

Comments

@dnfield
Copy link
Contributor

dnfield commented Feb 28, 2019

Today we only run packaging on dev/beta/stable. We should test it on master to make sure the script gets exercised.

/cc @gspencergoog
@dnfield dnfield added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Feb 28, 2019
@Hixie Hixie added the team-infra Owned by Infrastructure team label Sep 25, 2019
@timsneath timsneath changed the title [LUCI] We should test packaging on master without uploading. [LUCI] We should test packaging on master without uploading Jan 3, 2020
@godofredoc
Copy link
Contributor

@christopherfujino is it possible to run the packaging script in dry-run mode?

@christopherfujino
Copy link
Member

@dnfield what exactly would you like to catch? regressions in the script?

Sort of related:

@christopherfujino
Copy link
Member

Oh, I see that this was opened a while ago. My current plans are to migrate this script into the conductor, and then add integration tests there.

@christopherfujino christopherfujino added this to To do in Better Flutter Releases via automation Apr 23, 2021
@godofredoc
Copy link
Contributor

@christopherfujino can we close this issue now that we have the conductor tool ready?

@christopherfujino
Copy link
Member

@christopherfujino can we close this issue now that we have the conductor tool ready?

This is a different script than the conductor, https://github.com/flutter/flutter/blob/master/dev/bots/prepare_package.dart

@CaseyHillers CaseyHillers added the team-release Owned by Release team label Jun 24, 2022
@godofredoc
Copy link
Contributor

\cc @sealesj this is related to the work being done with packages.

@godofredoc godofredoc self-assigned this Dec 13, 2022
godofredoc added a commit to godofredoc/flutter that referenced this issue Dec 13, 2022
@godofredoc
Run packaging on presubtmit.
63cde36 
Test release package generation on presubmit.

Bug: flutter#28618
Bug: flutter#60706
@godofredoc godofredoc mentioned this issue Dec 13, 2022
Merged
8 tasks
Better Flutter Releases automation moved this from To do to Done Dec 16, 2022
auto-submit bot pushed a commit that referenced this issue Dec 16, 2022
@godofredoc
Run packaging on presubtmit. (#116943)
fa711f7 
* Run packaging on presubtmit.

Test release package generation on presubmit.

Bug: #28618
Bug: #60706

* Run packaging_test on all branches.
gspencergoog pushed a commit to gspencergoog/flutter that referenced this issue Jan 19, 2023
@godofredoc @gspencergoog
Run packaging on presubtmit. (flutter#116943)
afb3e35 
* Run packaging on presubtmit.

Test release package generation on presubmit.

Bug: flutter#28618
Bug: flutter#60706

* Run packaging_test on all branches.
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@godofredoc godofredoc

Labels
a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team team-release Owned by Release team
Projects
Better Flutter Releases
  
Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Hixie @CaseyHillers @digiter @christopherfujino @dnfield @godofredoc