Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share the alwaysUse24Hour and textScaleFactor heuristics between iOS and macOS #32006

Open
jonahwilliams opened this issue May 2, 2019 · 1 comment
Open

Share the alwaysUse24Hour and textScaleFactor heuristics between iOS and macOS #32006

jonahwilliams opened this issue May 2, 2019 · 1 comment
Labels
a: desktop Running on desktop c: proposal A detailed proposal for a change to Flutter engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project platform-mac Building on or for macOS specifically team-desktop Owned by Desktop platforms team triaged-desktop Triaged by Desktop platforms team

Comments

@jonahwilliams
Copy link
Member

I believe there should be some way to share, or otherwise keep this logic in sync, though it requires investigation. The code currently lives in the iOS FlutterViewController.
@jonahwilliams jonahwilliams added platform-mac Building on or for macOS specifically e: desktop labels May 2, 2019
@stuartmorgan
Copy link
Contributor

Looks like it should be as simple as pulling it out into a stand-alone utility function in a shared file.

@stuartmorgan stuartmorgan added engine flutter/engine repository. See also e: labels. a: desktop Running on desktop and removed e: desktop labels Jul 26, 2019
@stuartmorgan stuartmorgan added this to the No milestone necessary milestone Aug 13, 2019
@kf6gpe kf6gpe added the P6 label May 29, 2020
@TahaTesser TahaTesser added c: proposal A detailed proposal for a change to Flutter passed first triage labels Nov 5, 2020
@Hixie Hixie removed this from the No specific schedule milestone Dec 10, 2020
@flutter-triage-bot flutter-triage-bot bot added P3 Issues that are less important to the Flutter project and removed P6 labels Jun 28, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-desktop Owned by Desktop platforms team triaged-desktop Triaged by Desktop platforms team labels Jul 7, 2023
@knopp knopp mentioned this issue Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: desktop Running on desktop c: proposal A detailed proposal for a change to Flutter engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project platform-mac Building on or for macOS specifically team-desktop Owned by Desktop platforms team triaged-desktop Triaged by Desktop platforms team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stuartmorgan @Hixie @kf6gpe @jonahwilliams @TahaTesser