Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS plugin tooling #32718

Closed
stuartmorgan opened this issue May 14, 2019 · 1 comment · Fixed by #33636
Closed

Add macOS plugin tooling #32718

stuartmorgan opened this issue May 14, 2019 · 1 comment · Fixed by #33636
Assignees
@stuartmorgan
Labels
a: desktop Running on desktop platform-mac Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@stuartmorgan
Copy link
Contributor

We'll need flutter_tool support for adding the native portions of plugins to the build, including fetching dependencies, plugin registrant generation, etc.

Most likely this will use CocoaPods, re-using tooling already built for iOS.
@stuartmorgan stuartmorgan added tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically a: desktop Running on desktop labels May 14, 2019
@cloudwebrtc cloudwebrtc mentioned this issue May 18, 2019
Closed
@stuartmorgan stuartmorgan mentioned this issue May 22, 2019
Merged
9 tasks
@stuartmorgan stuartmorgan self-assigned this May 22, 2019
stuartmorgan added a commit to stuartmorgan/engine that referenced this issue May 22, 2019
@stuartmorgan
Add a podspec for FlutterMacOS.framework
5c7ba94 
Based on the iOS Flutter.podspec. This will be used for plugin
management via CocoaPods, as on iOS.

Part of flutter/flutter#32718
@stuartmorgan stuartmorgan mentioned this issue May 22, 2019
Merged
stuartmorgan added a commit to flutter/engine that referenced this issue May 22, 2019
@stuartmorgan
Add a podspec for FlutterMacOS.framework (#9062)
b17c0c6 
Based on the iOS Flutter.podspec. This will be used for plugin
management via CocoaPods, as on iOS.

Part of flutter/flutter#32718
stuartmorgan added a commit to stuartmorgan/engine that referenced this issue May 23, 2019
@stuartmorgan
Rename macOS FLEPlugin* to FlutterPlugin*
254914a 
As another step toward aligning the macOS plugin API with the iOS plugin
API, and with its final form, rename the plugin-related classes from
FLEPlugin* to FlutterPlugin*. This makes the names of the clasess the
same between iOS and macOS. Eventually they should actually merge, with
annotations/ifdefs for platform differences, but for now since the macOS
version uses the same method names and is simply a subset of the iOS
APIs (with one to-be-stabilized method that is macOS-specific) doing the
merge later won't be a breaking change.

Doing this now allows for building out plugin tooling and plugin
implementations on macOS without creating a growing body of code that
will experience a breaking change later.

See:
flutter/flutter#31735
flutter/flutter#32718
@stuartmorgan stuartmorgan mentioned this issue May 23, 2019
Merged
stuartmorgan added a commit to stuartmorgan/flutter that referenced this issue May 23, 2019
@stuartmorgan
Add macosPrefix to the pubspec schema for plugins
57f0a53 
Adds a new macosPrefix, which serves the same purpose as iosPrefix but
for macOS plugins.

It is not yet used by the tooling, but this allows for plugins to start
to be written using it in preparation for tooling support for plugins.

Part of flutter#32718
@stuartmorgan stuartmorgan mentioned this issue May 23, 2019
Merged
9 tasks
stuartmorgan added a commit that referenced this issue May 24, 2019
@stuartmorgan
Add macosPrefix to the pubspec schema for plugins (#33287)
0f6e4e6 
Adds a new macosPrefix, which serves the same purpose as iosPrefix but
for macOS plugins.

It is not yet used by the tooling, but this allows for plugins to start
to be written using it in preparation for tooling support for plugins.

Part of #32718
stuartmorgan added a commit to flutter/engine that referenced this issue May 26, 2019
@stuartmorgan
Rename macOS FLEPlugin* to FlutterPlugin* (#9074)
2404cdc 
As another step toward aligning the macOS plugin API with the iOS plugin
API, and with its final form, rename the plugin-related classes from
FLEPlugin* to FlutterPlugin*. This makes the names of the clasess the
same between iOS and macOS. Eventually they should actually merge, with
annotations/ifdefs for platform differences, but for now since the macOS
version uses the same method names and is simply a subset of the iOS
APIs (with one to-be-stabilized method that is macOS-specific) doing the
merge later won't be a breaking change.

Doing this now allows for building out plugin tooling and plugin
implementations on macOS without creating a growing body of code that
will experience a breaking change later.

See:
flutter/flutter#31735
flutter/flutter#32718
@stuartmorgan stuartmorgan mentioned this issue May 31, 2019
Merged
9 tasks
huqiuser pushed a commit to huqiuser/engine that referenced this issue Jun 12, 2019
@stuartmorgan
Add a podspec for FlutterMacOS.framework (flutter#9062)
5297c82 
Based on the iOS Flutter.podspec. This will be used for plugin
management via CocoaPods, as on iOS.

Part of flutter/flutter#32718
huqiuser pushed a commit to huqiuser/engine that referenced this issue Jun 12, 2019
@stuartmorgan
Rename macOS FLEPlugin* to FlutterPlugin* (flutter#9074)
3a586dc 
As another step toward aligning the macOS plugin API with the iOS plugin
API, and with its final form, rename the plugin-related classes from
FLEPlugin* to FlutterPlugin*. This makes the names of the clasess the
same between iOS and macOS. Eventually they should actually merge, with
annotations/ifdefs for platform differences, but for now since the macOS
version uses the same method names and is simply a subset of the iOS
APIs (with one to-be-stabilized method that is macOS-specific) doing the
merge later won't be a breaking change.

Doing this now allows for building out plugin tooling and plugin
implementations on macOS without creating a growing body of code that
will experience a breaking change later.

See:
flutter/flutter#31735
flutter/flutter#32718
kiku-jw pushed a commit to kiku-jw/flutter that referenced this issue Jun 14, 2019
@stuartmorgan @kiku-jw
Add macosPrefix to the pubspec schema for plugins (flutter#33287)
05d31cc 
Adds a new macosPrefix, which serves the same purpose as iosPrefix but
for macOS plugins.

It is not yet used by the tooling, but this allows for plugins to start
to be written using it in preparation for tooling support for plugins.

Part of flutter#32718
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan stuartmorgan

Labels
a: desktop Running on desktop platform-mac Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement plugin tooling support for macOS stuartmorgan/flutter
1 participant
@stuartmorgan