Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flutter update-packages --force-upgrade auto-roller #37985

Closed
jmagman opened this issue Aug 9, 2019 · 16 comments
Closed

Add a flutter update-packages --force-upgrade auto-roller #37985

jmagman opened this issue Aug 9, 2019 · 16 comments
Labels
P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team

Comments

@jmagman
Copy link
Member

jmagman commented Aug 9, 2019

Use case

Add an auto-roller to periodically merge the results of a flutter update-packages --force-upgrade if no tests fail.

@jmagman jmagman added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Aug 9, 2019
@jmagman
Copy link
Member Author

jmagman commented Aug 9, 2019

This has been mentioned a few times in a few chats, but I couldn't find an issue for it.

@jmagman
Copy link
Member Author

jmagman commented Aug 9, 2019

Right now this is done manually: #37971

@Hixie Hixie added this to the Goals milestone Aug 12, 2019
@Hixie
Copy link
Contributor

Hixie commented Dec 2, 2019

keywords: autoroller update packages force upgrade

@Hixie Hixie added the team-infra Owned by Infrastructure team label Dec 2, 2019
@Hixie
Copy link
Contributor

Hixie commented Dec 2, 2019

@godofredoc this would be a really useful bot, fwiw.

@Hixie
Copy link
Contributor

Hixie commented Dec 2, 2019

cc @dnfield since he's worked on some of our bots

@dnfield
Copy link
Contributor

dnfield commented Dec 2, 2019

@rmistry could this be a good candidate to fit in with what the Skia autorollers do?

We could write a custom bot to do this in Dart, but if there's already functionality to do it in the Skia autorollers that would be nice.

Effectively, we'd have to:

clone the repo
run flutter update-packages --force-upgrade
Commit the result of that
Open a PR with it.
cc or notify someone if it fails (it frequently can fail if, for example, a package we try to upgrade has a breaking change in it).

@zanderso
Copy link
Member

There are some examples of using github actions to accomplish what we want: https://github.com/peter-evans/create-pull-request/blob/master/docs/examples.md#use-case-create-a-pull-request-to-update-x-periodically. Thoughts about this approach?

@zanderso
Copy link
Member

/cc @jonahwilliams who I was just discussing this with.

@godofredoc
Copy link
Contributor

There are several restrictions on using github actions, we may need to validate with security before implementing.

@jmagman
Copy link
Member Author

jmagman commented Jan 15, 2021

There's also dependabot, if pub support gets implemented. dependabot/dependabot-core#2166

@LostInDarkMath

This comment has been minimized.

@jmagman

This comment has been minimized.

@LostInDarkMath

This comment has been minimized.

@godofredoc
Copy link
Contributor

@christopherfujino I believe you already implemented this, can we close this bug?

@christopherfujino
Copy link
Member

@christopherfujino I believe you already implemented this, can we close this bug?

Ahh thanks, didn't know about this! Closing as superceded by https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+autoroll+pub

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
None yet
Development

No branches or pull requests

8 participants