BottomAppBar should respect applyElevationOverlayColor

[orteney]

I'm not sure, but seems that follows to material spec BottomAppBar should have a white overlay in dark themes.

flutter doctor -v
[√] Flutter (Channel dev, v1.10.0, on Microsoft Windows [Version 10.0.18362.295], locale ru-RU)
    • Flutter version 1.10.0 at C:\Soft\flutter
    • Framework revision 3932ffb1cd (5 days ago), 2019-09-04 23:13:16 -0400
    • Engine revision e7f9ef6aa0
    • Dart version 2.5.0 (build 2.5.0-dev.4.0 36985859e4)


[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Soft\AndroidSdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: C:\Soft\JetBrains\apps\AndroidStudio\ch-2\192.5842447\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[!] Android Studio (version 3.6)
    • Android Studio at C:\Soft\JetBrains\apps\AndroidStudio\ch-2\192.5842447
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] IntelliJ IDEA Community Edition (version 2019.2)
    • IntelliJ at C:\Soft\JetBrains\apps\IDEA-C\ch-0\192.6262.58
    • Flutter plugin version 38.1.4
    • Dart plugin version 192.5728.98

[√] VS Code (version 1.38.0)
    • VS Code at C:\Users\d.orteney\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.4.1

[√] Connected device (1 available)
    • Chrome • chrome • web-javascript • Google Chrome 76.0.3809.132

[BondarenkoStas]

@orteney Can you please provide an example how it is now and it's supposed to be? Do you mean currently it's different from what's shown in the spec?

[HansMuller]

If you're referring to the white overlay that's added in dark mode to indicate elevation, the feature was added in #35560 (mid July).

[orteney]

@BondarenkoStas, sure, here is minimal example https://gist.github.com/orteney/50340b46cd7c4c88b73d27826dbe7f8f

As you can see BottomAppBar have 0% overlay. If following material dark theme specs it should be same color as Card with elevation = 8

p.s. using surfaceColor are following by spec (https://material.io/components/app-bars-bottom/#theming)

@HansMuller thanks, but ThemeData.from(colorScheme: ColorScheme.dark()) already enabled that)

[HansMuller]

CC @darrenaustin

[darrenaustin]

Yup, looks like the BottomButtonBar was missed on my Dark theme pass. Thanks for pointing it out.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.