Update BottomAppBar to use elevation overlays when in a dark theme #41864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenaustin
added
framework
darrenaustin
changed the title
class and made it private to the material package.
darrenaustin
force-pushed
the
bottom_app_bar_overlay
branch
from
c744191
to
6761020
Compare
…hide it. Small updates from code review feedback.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…lutter#41864) * Updated the BottomAppBar to use elevation overlays when a dark theme is used. * Moved the code for calculating the overlay color to a new utility ElevationOverlay class and made it private by not including in the material package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a
BottomAppBaris inside a dark theme, it should respect theThemeData.applyElevationOverlayand apply a semi-transparent color overlay to its background color based on elevation (see the dark theme spec).Related Issues
Fixes: #40122
Tests
I added a test to ensure the BottomAppBar has an overlay in a dark theme.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?