Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The engine should be tested with 32 bit iOS builds #40450

Closed
mklim opened this issue Sep 13, 2019 · 5 comments
Closed

The engine should be tested with 32 bit iOS builds #40450

mklim opened this issue Sep 13, 2019 · 5 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team

Comments

@mklim
Copy link
Contributor

mklim commented Sep 13, 2019

Right now the only tests we have for this build are the device lab tests, which means regressions to this in Dart and the engine aren't caught until it's time to roll. So far this has caused two separate issues with the current roll. #40114 and flutter/engine#12263.

/cc @dnfield

@mklim mklim added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. platform-ios iOS applications specifically engine flutter/engine repository. See also e: labels. labels Sep 13, 2019
@dnfield
Copy link
Contributor

dnfield commented Sep 13, 2019

For posterity - it appears that there are still a substantial number of users out there with older iPads and even iPhone 4/4S out there that would need this.

Unfortunately, I'm not aware of any good OOB way to test this. Even if we could find a 32 bit emulator for it, that would stop working soon on Catalina. We'd need something like our devicelab setup to test this, with our own stock of 32 bit devices.

@Hixie Hixie added the team-infra Owned by Infrastructure team label Sep 25, 2019
@mehmetf
Copy link
Contributor

mehmetf commented Dec 2, 2019

For posterity - it appears that there are still a substantial number of users out there with older iPads and even iPhone 4/4S out there that would need this.

Do we have data to back this up? I found some websites attempting to quantify the market share of various iPhone models (such as https://david-smith.org/iosversionstats/) but there's no definitive answer. According to that link for instance, less than 0.2% of users use a 32-bit device. Then again, that's users of a popular AudioBook app so I don't think India is their target market.

@dnfield
Copy link
Contributor

dnfield commented Dec 2, 2019

The david-smith site is the closest I've found to data on that - but .2% is still a large number of customers for some segments.

It would be good to get any internal metrics we have on that (for any apps we have that still run on 32 bit iPads). We could also try to reach out to some of our other partners.

@jmagman jmagman added this to Awaiting triage in Mobile - team support review Feb 25, 2020
@jmagman jmagman moved this from Awaiting triage to Engineer reviewed in Mobile - team support review Mar 23, 2020
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label Dec 9, 2020
@jmagman jmagman added this to Awaiting triage in iOS Platform - team support review Jun 8, 2021
@jmagman jmagman moved this from Awaiting triage to Engineer reviewed in iOS Platform - team support review Jun 23, 2021
@jmagman
Copy link
Member

jmagman commented Jan 27, 2022

We're about to remove support for 32-bit iOS, see #97327. Closing.

@jmagman jmagman closed this as completed Jan 27, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
Mobile - team support review
  
Engineer reviewed
Development

No branches or pull requests

8 participants