Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine roll causing observatory connection timeouts on 32-bit iPhones #40114

Closed
gspencergoog opened this issue Sep 9, 2019 · 23 comments
Closed

Engine roll causing observatory connection timeouts on 32-bit iPhones #40114

gspencergoog opened this issue Sep 9, 2019 · 23 comments
Assignees
@mklim
Labels
dependency: dart Dart team may need to help us e: device-specific Only manifests on certain devices engine flutter/engine repository. See also e: labels.

Comments

@gspencergoog
Copy link
Contributor

gspencergoog commented Sep 9, 2019 •
edited

I reverted two engine rolls in #40112 because the were causing failures in devicelab tests that were failing with timeouts trying to connect to the observatory: flutter_gallery_ios32__transition_perf and flutter_gallery_ios32__start_up.

I HAVE STOPPED THE ENGINE ROLL, so someone needs to restart it once this is resolved.

Specifically, they started failing when af07bb5 was committed, which includes a Dart roll that is probably suspect:

2019-09-06 bkonyi@google.com Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)

Here is a sample log output of one of the tests (both are similar):

2019-09-09T14:09:01.547976: stdout: [  +40 ms] (lldb)     run
2019-09-09T14:09:03.005319: stdout: [+1457 ms] success
stdout: [        ] (lldb)     safequit
2019-09-09T14:09:03.132474: stdout: [ +125 ms] Process 248 detached
2019-09-09T14:09:03.159828: stdout: [  +28 ms] Application launched on the device. Waiting for observatory port.
2019-09-09T14:21:27.297237: Task timed out in framework.dart after 0:15:00.000000.
Cleaning up after task...
2019-09-09T14:21:28.310369: Force-quitting process:
command : bin/flutter run --verbose --profile --trace-startup -d [device id redacted]
  started : 2019-09-09 14:06:29.482349
  pid     : 12227
2019-09-09T14:21:28.318085: "bin/flutter" exit code: -15
2019-09-09T14:21:29.329736: Task execution finished

Task failed with the following reason:
Timeout waiting for task process to exit: Future not completed
@gspencergoog gspencergoog added e: device-specific Only manifests on certain devices engine flutter/engine repository. See also e: labels. ⚠ TODAY labels Sep 9, 2019
@gspencergoog
Copy link
Contributor Author

gspencergoog commented Sep 9, 2019 •
edited

Note that reverting this also fixed a problem in flutter_gallery__back_button_memory. It's unclear if this engine roll is the culprit there, since it seemed to pass on the initial commit (but failed every build thereafter until I reverted this). And it's also not on 32-bit iOS, so there may be concurrent unconnected problems here.

@blasten
Copy link

blasten commented Sep 10, 2019

Should we still keep the TODAY label @gspencergoog ?

@tvolkert tvolkert mentioned this issue Sep 10, 2019
Merged
@tvolkert
Copy link
Contributor

Yes, this should stay TODAY, as the engine auto-roller is blocked on reverting the culprit in the engine or Dart SDK.

@mklim mklim assigned mklim and unassigned chinmaygarde Sep 10, 2019
@mklim

This comment has been minimized.

Sign in to view
@mklim

This comment has been minimized.

Sign in to view
flar referenced this issue Sep 11, 2019
@gspencergoog
Revert engine roll (#40112)
399bb04 
Reverting the engine rolls that seem to have caused the following devicelab tests to start timing out:

flutter_gallery_ios32__transition_perf and flutter_gallery_ios32__start_up.

Specifically, they started failing when af07bb5 was committed.
flar referenced this issue Sep 11, 2019
@engine-flutter-autoroll
Roll engine 7ea9884..50bdbd7 (3 commits) (#40017)
af07bb5 
git@github.com:flutter/engine.git/compare/7ea9884ab00e...50bdbd7

git log 7ea9884..50bdbd7 --no-merges --oneline
2019-09-06 egarciad@google.com Document dependencies and remove support-v13 (flutter/engine#11912)
2019-09-06 bkonyi@google.com Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)
2019-09-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter/engine#12031)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
flar referenced this issue Sep 11, 2019
@engine-flutter-autoroll
c9ea4db [flutter_runner] Refactor our build rules to make them more i…
5a3a46a 
…nline with topaz. (flutter/engine#12034) (#40018)

git@github.com:flutter/engine.git/compare/50bdbd769eee...c9ea4db

git log 50bdbd7..c9ea4db --no-merges --oneline
2019-09-06 iska.kaushik@gmail.com [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter/engine#12034)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@mklim
Copy link
Contributor

mklim commented Sep 11, 2019 •
edited

Okay, I can reliably reproduce this now. It has to do with profile mode specifically. Just flutter run or building the engine in debug mode isn't enough to repro. But flutter run --profile will briefly launch the app, the app will crash, and then the tool will hang.

The log I mentioned above doesn't appear with this. I think it was just a one-off local build error.

@blasten
Copy link

blasten commented Sep 11, 2019

@mklim thanks for looking into it. Do you know what is causing the app to crash?

@mklim
Copy link
Contributor

mklim commented Sep 11, 2019

@blasten not yet, picking up the investigation again this morning.

@mklim
Copy link
Contributor

mklim commented Sep 11, 2019

I've bisected this to a Dart roll, flutter/engine@0c6a538.

@mklim mklim added the dependency: dart Dart team may need to help us label Sep 11, 2019
@tvolkert
Copy link
Contributor

Can we revert the engine back to the Dart revision before that commit, pause the Dart SDK rolls until this is resolved, and resume the engine auto-rolls?

@tvolkert
Copy link
Contributor

@a-siva

@mklim
Copy link
Contributor

mklim commented Sep 11, 2019

I'll roll back the Dart revision in the engine.

@mklim mklim mentioned this issue Sep 11, 2019
Merged
@mklim
Copy link
Contributor

mklim commented Sep 11, 2019

Obfuscated stack trace from the Console, seems to be the only thing that has logs:

default	11:28:16.000000 -0700	com.apple.xpc.launchd	 Service exited due to signal: Segmentation fault: 11

default	11:28:16.000000 -0700	SpringBoard	 Application 'UIKitApplication:io.flutter.examples.gallery[0xb100]' crashed.

default	11:28:16.000000 -0700	UserEventAgent	 2223349934329: id=io.flutter.examples.gallery pid=1402, state=0

default	12:28:16.000000 -0700	ReportCrash	 assertion failed: 13G36: libsystem_trace.dylib + 15927 [E82A6F2D-873A-39AD-8014-EDEB52248157]: 0x0

default	11:28:16.000000 -0700	ReportCrash	 Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
	Exception Subtype: KERN_INVALID_ADDRESS at 0x4d4b2137
	Triggered by Thread:  11

default	11:28:16.000000 -0700	ReportCrash	 Thread 0 name:  Dispatch queue: com.apple.main-thread
	Thread 0:
	0   libsystem_kernel.dylib        	0x25bf2998 0x25bde000 + 84376
	1   libsystem_pthread.dylib       	0x25c9adec 0x25c98000 + 11756
	2   libsystem_pthread.dylib       	0x25c9bc98 0x25c98000 + 15512
	3   libc++.1.dylib                	0x2569886c 0x25692000 + 26732
	4   Flutter                       	0x0018dbb6 0x156000 + 228278
	5   Flutter                       	0x001cbfbc 0x156000 + 483260
	6   Flutter                       	0x001cb28c 0x156000 + 479884
	7   Flutter                       	0x00162c00 0x156000 + 52224
	8   Flutter                       	0x00171d9e 0x156000 + 114078
	9   Flutter                       	0x00171e98 0x156000 + 114328
	10  UIKit                         	0x2a997796 0x2a4cf000 + 5015446
	11  UIKit                         	0x2aaaf10e 0x2a4cf000 + 6160654
	12  UIKit                         	0x2aaaedf4 0x2a4cf000 + 6159860
	13  UIKit                         	0x2a997476 0x2a4cf000 + 5014646
	14  UIKit                         	0x2aaaf10e 0x2a4cf000 + 6160654
	15  UIKit                         	0x2aaaf0a0 0x2a4cf000 + 6160544
	16  UIKit                         	0x2aaaedf4 0x2a4cf000 + 6159860
	17  UIKit                         	0x2a996a0a 0x2a4cf000 + 5011978
	18  UIKit                         	0x2abe8568 0x2a4cf000 + 7443816
	19  UIKit                         	0x2abe86ca 0x2a4cf000 + 7444170
	20  UIKit                         	0x2a7842c8 0x2a4cf000 + 2839240
	21  UIKit                         	0x2a557444 0x2a4cf000 + 558148
	22  UIKit                         	0x2a78314a 0x2a4cf000 + 2834762
	23  UIKit                         	0x2a79783c 0x2a4cf000 + 2918460
	24  UIKit                         	0x2a7807b2 0x2a4cf000 + 2824114
	25  FrontBoardServices            	0x2760ac06 0x275e6000 + 150534
	26  FrontBoardServices            	0x2760aab8 0x275e6000 + 150200
	27  FrontBoardServices            	0x2760adb8 0x275e6000 + 150968
	28  CoreFoundation                	0x25f29dfe 0x25e6e000 + 769534
	29  CoreFoundation                	0x25f299ec 0x25e6e000 + 768492
	30  CoreFoundation                	0x25f27d5a 0x25e6e000 + 761178
	31  CoreFoundation                	0x25e77228 0x25e6e000 + 37416
	32  CoreFoundation                	0x25e77014 0x25e6e000 + 36884
	33  UIKit                         	0x2a550c3c 0x2a4cf000 + 531516
	34  UIKit                         	0x2a54b188 0x2a4cf000 + 508296
	35  Runner                        	0x0002e66c 0x2a000 + 18028
	36  libdyld.dylib                 	0x25b1f872 0x25b1d000 + 10354

default	11:28:16.000000 -0700	ReportCrash	 Thread 1 name:  Dispatch queue: com.apple.libdispatch-manager
	Thread 1:
	0   libsystem_kernel.dylib        	0x25bf42f8 0x25bde000 + 90872
	1   libdispatch.dylib             	0x25ae9d60 0x25ad3000 + 93536
	2   libdispatch.dylib             	0x25ae9abe 0x25ad3000 + 92862

default	11:28:16.000000 -0700	ReportCrash	 Thread 2:
	0   libsystem_kernel.dylib        	0x25bf3864 0x25bde000 + 88164
	1   libsystem_pthread.dylib       	0x25c99b34 0x25c98000 + 6964
	2   libsystem_pthread.dylib       	0x25c99718 0x25c98000 + 5912

default	10:28:16.000000 -0800	ReportCrash	 Thread 3:
	0   libsystem_kernel.dylib        	0x25bf3864 0x25bde000 + 88164
	1   libsystem_pthread.dylib       	0x25c99b34 0x25c98000 + 6964
	2   libsystem_pthread.dylib       	0x25c99718 0x25c98000 + 5912

default	11:28:16.000000 -0700	ReportCrash	 Thread 4:
	0   libsystem_kernel.dylib        	0x25bf3864 0x25bde000 + 88164
	1   libsystem_pthread.dylib       	0x25c99b34 0x25c98000 + 6964
	2   libsystem_pthread.dylib       	0x25c99718 0x25c98000 + 5912

default	11:28:16.000000 -0700	ReportCrash	 Thread 5 name:  io.flutter.1.ui
	Thread 5:
	0   App                           	0x00f50f98 0xf2a000 + 159640
	1   Flutter                       	0x00518a6e 0x156000 + 3943022
	2   Flutter                       	0x005c9246 0x156000 + 4665926
	3   Flutter                       	0x001aff3e 0x156000 + 368446
	4   Flutter                       	0x001af436 0x156000 + 365622
	5   Flutter                       	0x001aede4 0x156000 + 364004
	6   Flutter                       	0x001b6d94 0x156000 + 396692
	7   Flutter                       	0x001bc0b4 0x156000 + 417972
	8   Flutter                       	0x001c8a5a 0x156000 + 469594
	9   Flutter                       	0x0018ca6c 0x156000 + 223852
	10  Flutter                       	0x0018e91a 0x156000 + 231706
	11  CoreFoundation                	0x25f2a58e 0x25e6e000 + 771470
	12  CoreFoundation                	0x25f2a1c0 0x25e6e000 + 770496
	13  CoreFoundation                	0x25f2800c 0x25e6e000 + 761868
	14  CoreFoundation                	0x25e77228 0x25e6e000 + 37416
	15  CoreFoundation                	0x25e77014 0x25e6e000 + 36884
	16  Flutter                       	0x0018e79a 0x156000 + 231322
	17  Flutter                       	0x0018e0b8 0x156000 + 229560
	18  libsystem_pthread.dylib       	0x25c9b85a 0x25c98000 + 14426
	19  libsystem_pthread.dylib       	0x25c9b7ce 0x25c98000 + 14286
	20  libsystem_pthread.dylib       	0x25c99724 0x25c98000 + 5924

default	11:28:16.000000 -0700	ReportCrash	 Thread 6 name:  io.flutter.1.gpu
	Thread 6:
	0   libsystem_kernel.dylib        	0x25bde8d0 0x25bde000 + 2256
	1   libsystem_kernel.dylib        	0x25bde6d4 0x25bde000 + 1748
	2   CoreFoundation                	0x25f29ac4 0x25e6e000 + 768708
	3   CoreFoundation                	0x25f27e4c 0x25e6e000 + 761420
	4   CoreFoundation                	0x25e77228 0x25e6e000 + 37416
	5   CoreFoundation                	0x25e77014 0x25e6e000 + 36884
	6   Flutter                       	0x0018e79a 0x156000 + 231322
	7   Flutter                       	0x0018e0b8 0x156000 + 229560
	8   libsystem_pthread.dylib       	0x25c9b85a 0x25c98000 + 14426
	9   libsystem_pthread.dylib       	0x25c9b7ce 0x25c98000 + 14286
	10  libsystem_pthread.dylib       	0x25c99724 0x25c98000 + 5924

default	11:28:16.000000 -0700	ReportCrash	 Thread 7 name:  io.flutter.1.io
	Thread 7:
	0   libsystem_kernel.dylib        	0x25bde8d0 0x25bde000 + 2256
	1   libsystem_kernel.dylib        	0x25bde6d4 0x25bde000 + 1748
	2   CoreFoundation                	0x25f29ac4 0x25e6e000 + 768708
	3   CoreFoundation                	0x25f27e4c 0x25e6e000 + 761420
	4   CoreFoundation                	0x25e77228 0x25e6e000 + 37416
	5   CoreFoundation                	0x25e77014 0x25e6e000 + 36884
	6   Flutter                       	0x0018e79a 0x156000 + 231322
	7   Flutter                       	0x0018e0b8 0x156000 + 229560
	8   libsystem_pthread.dylib       	0x25c9b85a 0x25c98000 + 14426
	9   libsystem_pthread.dylib       	0x25c9b7ce 0x25c98000 + 14286
	10  libsystem_pthread.dylib       	0x25c99724 0x25c98000 + 5924

default	11:28:16.000000 -0700	ReportCrash	 Thread 8 name:  io.flutter.worker.1
	Thread 8:
	0   libsystem_kernel.dylib        	0x25bf2998 0x25bde000 + 84376
	1   libsystem_pthread.dylib       	0x25c9adec 0x25c98000 + 11756
	2   libsystem_pthread.dylib       	0x25c9bc98 0x25c98000 + 15512
	3   libc++.1.dylib                	0x2569886c 0x25692000 + 26732
	4   Flutter                       	0x00189d74 0x156000 + 212340
	5   libsystem_pthread.dylib       	0x25c9b85a 0x25c98000 + 14426
	6   libsystem_pthread.dylib       	0x25c9b7ce 0x25c98000 + 14286
	7   libsystem_pthread.dylib       	0x25c99724 0x25c98000 + 5924

default	11:28:16.000000 -0700	ReportCrash	 Thread 9 name:  io.flutter.worker.2
	Thread 9:
	0   libsystem_kernel.dylib        	0x25bf2998 0x25bde000 + 84376
	1   libsystem_pthread.dylib       	0x25c9adec 0x25c98000 + 11756
	2   libsystem_pthread.dylib       	0x25c9bc98 0x25c98000 + 15512
	3   libc++.1.dylib                	0x2569886c 0x25692000 + 26732
	4   Flutter                       	0x00189d74 0x156000 + 212340
	5   libsystem_pthread.dylib       	0x25c9b85a 0x25c98000 + 14426
	6   libsystem_pthread.dylib       	0x25c9b7ce 0x25c98000 + 14286
	7   libsystem_pthread.dylib       	0x25c99724 0x25c98000 + 5924

default	11:28:16.000000 -0700	ReportCrash	 Thread 10 name:  dart:io EventHandler
	Thread 10:
	0   libsystem_kernel.dylib        	0x25be1de0 0x25bde000 + 15840
	1   Flutter                       	0x00410300 0x156000 + 2859776
	2   Flutter                       	0x00434ba0 0x156000 + 3009440
	3   libsystem_pthread.dylib       	0x25c9b85a 0x25c98000 + 14426
	4   libsystem_pthread.dylib       	0x25c9b7ce 0x25c98000 + 14286
	5   libsystem_pthread.dylib       	0x25c99724 0x25c98000 + 5924

default	11:28:16.000000 -0700	ReportCrash	 Thread 11 name:  Dart ThreadPool Worker
	Thread 11 Crashed:
	0   App                           	0x00f50f98 0xf2a000 + 159640
	1   Flutter                       	0x00518a6e 0x156000 + 3943022
	2   Flutter                       	0x005c9246 0x156000 + 4665926
	3   Flutter                       	0x001aff3e 0x156000 + 368446
	4   Flutter                       	0x001af436 0x156000 + 365622
	5   Flutter                       	0x001aede4 0x156000 + 364004
	6   Flutter                       	0x001b1604 0x156000 + 374276
	7   Flutter                       	0x00574ba0 0x156000 + 4320160
	8   Flutter                       	0x00584370 0x156000 + 4383600
	9   Flutter                       	0x0052ea6c 0x156000 + 4033132
	10  libsystem_pthread.dylib       	0x25c9b85a 0x25c98000 + 14426
	11  libsystem_pthread.dylib       	0x25c9b7ce 0x25c98000 + 14286
	12  libsystem_pthread.dylib       	0x25c99724 0x25c98000 + 5924

default	11:28:16.000000 -0700	ReportCrash	 Thread 11 crashed with ARM Thread State (32-bit):
	    r0: 0x1504efec    r1: 0xe5926007      r2: 0x4d4b1300      r3: 0x1504be00
	    r4: 0x1504efd4    r5: 0x1504efec      r6: 0x00b04c64      r7: 0x1f523cb0
	    r8: 0x4d4b1300    r9: 0x00000000     r10: 0x00f338e0     r11: 0x1504ef74
	    ip: 0x1504ef94    sp: 0x1f523878      lr: 0x00f343dc      pc: 0x00f50f98
	  cpsr: 0x00000010

mklim pushed a commit to flutter/engine that referenced this issue Sep 11, 2019
Revert "Roll src/third_party/dart be66176..ec7ec4e (37 commits)" (#12223
5b94c8a 
)

flutter/flutter#40114
@mklim
Copy link
Contributor

mklim commented Sep 11, 2019 •
edited

I've created a manual roll of the engine with the Dart SDK revert at #40275. It doesn't appear to have this particular regression, but it's also still going through CI and has 64 commits since the last roll.

@aam
Copy link
Member

aam commented Sep 11, 2019

Culprit seems to be dart-lang/sdk@c219a76

cc @sjindel-google @alexmarkov

@mklim
Copy link
Contributor

mklim commented Sep 11, 2019

The manual roll has landed and the engine to framework roller has been turned back on. The dart to engine roller is still paused.

@tvolkert
Copy link
Contributor

Thanks @mklim - I think we can remove the TODAY label now to unblock dev rolls.

@aam
Copy link
Member

aam commented Sep 12, 2019

Sent out https://dart-review.googlesource.com/c/sdk/+/116883 with revert in dart sdk, so dart-to-engine roll can be resumed

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Sep 12, 2019
@aam
Revert Reland '[vm/ffi] Implement FFI callbacks on AOT for ELF and As…
0c481a1 
…m snapshots (excl. blobs).' as it breaks flutter profile execution on ios 32-bit platform.

Fixes flutter/flutter#40114

Change-Id: If8d71e9c19c2e794d29f7ecbacb87457890a2fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116883
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@sjindel-google
Copy link
Contributor

@mklim What app did you run to reproduce the crash? Also, did it happen on 64-bit iOS or only 32-bit?

@aam
Copy link
Member

aam commented Sep 12, 2019

@sjindel-google I used flutter gallery (in profile/release mode). ios 32-bit was the only affected as far as I know.

@mklim
Copy link
Contributor

mklim commented Sep 12, 2019

@sjindel-google my testing was the same as @aam's.

@mklim
Copy link
Contributor

mklim commented Sep 12, 2019

I've resumed the dart to engine roller since the revert landed in dart-lang/sdk@0c481a1. I think it's safe to consider this fixed now.

@mklim mklim closed this as completed Sep 12, 2019
This was referenced Sep 12, 2019
Closed
Merged
mklim pushed a commit that referenced this issue Sep 12, 2019
Roll engine from 7ea9884..3c6383f (77 commits 🔥) (#40372)
d4b1f49 
There are overlapping TODAY issues (#40303 and #40114) that prevent this
roll from being split up further.

git log 7ea9884..3c6383f --no-merges --oneline

3c6383f Revert "Smooth out iOS irregular input events delivery (#11817)" (#12251)
d6f0b64 pin and auto-install chrome version (#12228)
2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (#12250)
dfa9498 Enable platform view keyboard input on Android Q (#12085)
bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (#12238)
58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (#12237)
c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (#12235)
cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (#12236)
bbb1f12 Adjust iOS frame start times to match the platform info (#11802)
1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (#12231)
da84d59 Revert "Manage iOS contexts separately (#12078)" (#12233)
4ac0663 Manage iOS contexts separately (#12078)
28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (#12224)
5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (#12223)
988efe3 Do not generate kernel platform files on topaz tree (#12222)
6c46a17 Don't disable toString in release mode for dart:ui classes (#12204)
80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (#12221)
7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (#12220)
c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (#12219)
2bdfb61 Namespace patched SDK names to not conflict with Topaz (#12218)
ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits)
2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (#12216)
d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (#12215)
c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (#12214)
5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits)
e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (#12212)
6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (#12210)
96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (#12209)
34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (#12207)
92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (#12206)
e174b4b Don't load Roboto by default (#12205)
efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits)
5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (#12202)
e9c9984 add a convenience CLI tool for building and testing web engine (#12197)
bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (#12048)
954f198 Add custom test plugin that supports screenshot tests (#12079)
d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (#12190)
c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits)
cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (#12178)
2592d6e [flutter_runner] Port the accessibility bridge from Topaz (#12054)
b569e8c Smooth out iOS irregular input events delivery (#11817)
dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits)
2438798 Make ImageShader implement Shader for web ui (#12161)
c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits)
4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (#12151)
548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (#12129)
f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (#12106)
19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (#12088)
d816755 Don't launch the observatory by default on each embedder unit-test invocation. (#12087)
39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (#12086)
b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits)
03e773a Guard availability of user notification related methods to iOS 10.0 (#12084)
9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (#9864)
c2e8289 Add GradientRadial paintStyle implementation (#12081)
c3eea0a Don't quote generic font families (#12080)
c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (#12082)
a4de006 Remove ENABLE_BITCODE from Scenarios test app (#11839)
6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (#12077)
e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (#12075)
359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (#12074)
38d545e Improve Unicode handling on Windows (#11899)
89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (#12072)
dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (#12071)
8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (#11808)
aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (#12070)
075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (#12068)
a610505 option for --no-lto for fuchsia (#12010)
be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (#12067)
6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (#12059)
e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits)
723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (#12058)
35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)" (#12055)
a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)
c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (#12034)
50bdbd7 Document dependencies and remove support-v13 (#11912)
0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)
37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (#12031)
@mklim mklim mentioned this issue Sep 13, 2019
Closed
@sjindel-google sjindel-google mentioned this issue Sep 17, 2019
Closed
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Sep 25, 2019
@sjindel-google
[vm] Support testing assembly snapshots for ARM.
9a683de 
We have had several bugs propagate to Flutter end-users due to our lack of testing of
AOT Assembly snapshots on ARM (SIMARM_X64 in particular), causing reverts of SDK commits
and disrupting the Dart -> Flutter roll.

This leverages our custom ELF loader to load the generated ELF objects, which cannot be
loaded by dlopen() because they are marked with the ARM ABI.

For example, see:
  - flutter/flutter#40114
  - flutter/flutter#41228

Also do some tree-shaking of the snapshot writers for dart_precompiled_runtime.

Fixes #38433.

Change-Id: I5990769c623b8a13131b1848349af2c0a026272b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118569
Reviewed-by: Clement Skau <cskau@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Sep 25, 2019
@sjindel-google
[vm] Switch vm-kernel-precomp-mac-debug-simarm_x64 to vm-kernel-preco…
1c8e5f0 
…mp-linux-debug-simarm_x64.

The reason is that we can test Assembly snapshot generation on Linux but not on Mac.

We have had several bugs propagate to Flutter end-users due to our lack of testing of
AOT Assembly snapshots on ARM (SIMARM_X64 in particular), causing reverts of SDK commits
and disrupting the Dart -> Flutter roll.

For example, see:
  - flutter/flutter#40114
  - flutter/flutter#41228

Change-Id: Ided8116e8230e58ffd350447b2e1a22676bd0506
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118584
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this issue Sep 30, 2019
@Inconnu08
Roll engine from 7ea9884..3c6383f (77 commits 🔥) (flutter#40372)
fcec123 
There are overlapping TODAY issues (flutter#40303 and flutter#40114) that prevent this
roll from being split up further.

git log 7ea9884..3c6383f --no-merges --oneline

3c6383f Revert "Smooth out iOS irregular input events delivery (flutter#11817)" (flutter#12251)
d6f0b64 pin and auto-install chrome version (flutter#12228)
2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (flutter#12250)
dfa9498 Enable platform view keyboard input on Android Q (flutter#12085)
bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (flutter#12238)
58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (flutter#12237)
c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (flutter#12235)
cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (flutter#12236)
bbb1f12 Adjust iOS frame start times to match the platform info (flutter#11802)
1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (flutter#12231)
da84d59 Revert "Manage iOS contexts separately (flutter#12078)" (flutter#12233)
4ac0663 Manage iOS contexts separately (flutter#12078)
28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (flutter#12224)
5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter#12223)
988efe3 Do not generate kernel platform files on topaz tree (flutter#12222)
6c46a17 Don't disable toString in release mode for dart:ui classes (flutter#12204)
80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter#12221)
7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter#12220)
c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter#12219)
2bdfb61 Namespace patched SDK names to not conflict with Topaz (flutter#12218)
ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits)
2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter#12216)
d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter#12215)
c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter#12214)
5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits)
e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter#12212)
6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter#12210)
96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter#12209)
34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter#12207)
92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (flutter#12206)
e174b4b Don't load Roboto by default (flutter#12205)
efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits)
5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter#12202)
e9c9984 add a convenience CLI tool for building and testing web engine (flutter#12197)
bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (flutter#12048)
954f198 Add custom test plugin that supports screenshot tests (flutter#12079)
d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (flutter#12190)
c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits)
cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter#12178)
2592d6e [flutter_runner] Port the accessibility bridge from Topaz (flutter#12054)
b569e8c Smooth out iOS irregular input events delivery (flutter#11817)
dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits)
2438798 Make ImageShader implement Shader for web ui (flutter#12161)
c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits)
4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter#12151)
548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter#12129)
f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter#12106)
19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter#12088)
d816755 Don't launch the observatory by default on each embedder unit-test invocation. (flutter#12087)
39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter#12086)
b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits)
03e773a Guard availability of user notification related methods to iOS 10.0 (flutter#12084)
9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter#9864)
c2e8289 Add GradientRadial paintStyle implementation (flutter#12081)
c3eea0a Don't quote generic font families (flutter#12080)
c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (flutter#12082)
a4de006 Remove ENABLE_BITCODE from Scenarios test app (flutter#11839)
6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (flutter#12077)
e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (flutter#12075)
359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (flutter#12074)
38d545e Improve Unicode handling on Windows (flutter#11899)
89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (flutter#12072)
dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (flutter#12071)
8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (flutter#11808)
aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (flutter#12070)
075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (flutter#12068)
a610505 option for --no-lto for fuchsia (flutter#12010)
be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (flutter#12067)
6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (flutter#12059)
e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits)
723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (flutter#12058)
35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798)" (flutter#12055)
a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798)
c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter#12034)
50bdbd7 Document dependencies and remove support-v13 (flutter#11912)
0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)
37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter#12031)
tekknolagi pushed a commit to tekknolagi/dart-assembler that referenced this issue Nov 3, 2020
@aam
Revert Reland '[vm/ffi] Implement FFI callbacks on AOT for ELF and As…
e27ceb5 
…m snapshots (excl. blobs).' as it breaks flutter profile execution on ios 32-bit platform.

Fixes flutter/flutter#40114

Change-Id: If8d71e9c19c2e794d29f7ecbacb87457890a2fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116883
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mklim mklim

Labels
dependency: dart Dart team may need to help us e: device-specific Only manifests on certain devices engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@chinmaygarde @aam @blasten @mklim @gspencergoog @tvolkert @sjindel-google