New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[url_launcher] Add desktop support #41721

Closed

3 tasks done

stuartmorgan opened this issue Oct 1, 2019 · 11 comments · Fixed by flutter/plugins#3024

Closed

3 tasks done

[url_launcher] Add desktop support #41721

stuartmorgan opened this issue Oct 1, 2019 · 11 comments · Fixed by flutter/plugins#3024

Assignees

Labels

a: desktop good first issue p: url_launcher P1 package platform-windows

Projects

Windows Preview Linux Preview

Milestone

1.23 - September ...

Contributor

stuartmorgan commented Oct 1, 2019 •

edited

Filing this a consolidate bug for all three desktop platform since there are already FDE implementations for all three. This bug is to track moving them over to flutter/plugins as each platform's plugin tooling and APIs stabilize:

macOS
Windows
Linux

stuartmorgan added plugin platform-mac platform-windows platform-linux p: url_launcher a: desktop labels

Contributor Author

stuartmorgan commented Oct 1, 2019

Assigning myself for macOS since that will be ready to move very soon.

stuartmorgan self-assigned this

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue


          Adds macOS support for url_launche

4e6749a

Follows the structure established in flutter#2119 to add a federated macOS
implementation of the url_launcher plugin.

Fixes macOS portion of flutter/flutter#41721

This was referenced Oct 14, 2019

[url_launcher] Adds macOS support flutter/plugins#2187

Closed

Unhandled Exception: MissingPluginException in Flutter Desktop(Windows) #42868

Closed

This was referenced Dec 7, 2019

[url_launcher] Add support for macos flutter/plugins#2377

Closed

[url_launcher] Adds macOS package with example app flutter/plugins#2383

Merged

stuartmorgan removed their assignment

stuartmorgan added this to To do in Windows Preview via automation

stuartmorgan added this to To do in Linux Preview via automation

Contributor Author

stuartmorgan commented Apr 21, 2020

Blocked on #55327 for Linux. Once that's done we can easily do this as a Dart-only "plugin".

Contributor Author

stuartmorgan commented Jun 3, 2020

The first Dart-only Linux plugin (path_provider+path_provider_linux) is landed and published, so doing the Linux version of url_launcher should be straightforward; it just needs to do this using Dart's Process.

stuartmorgan added the good first issue label

csells assigned robert-ancell

stuartmorgan added this to the 1.20 - June 2020 milestone

stuartmorgan added the P1 label

stuartmorgan removed this from the 1.20 - June 2020 milestone

robert-ancell moved this from To do to In progress in Linux Preview

Contributor

robert-ancell commented Jun 10, 2020

The first Dart-only Linux plugin (path_provider+path_provider_linux) is landed and published, so doing the Linux version of url_launcher should be straightforward; it just needs to do this using Dart's Process.

This may actually be more reliable/simpler with the GTK shell to implement in C++ with g_app_info_launch_default_for_uri().

Contributor Author

stuartmorgan commented Jun 10, 2020

Ah, good to know. It looks like there's also g_app_info_get_default_for_uri_scheme as a reliable way to implement canLaunch, which we currently don't have.

This seems like a good candidate for a Dart-with-FFI-to-system-library "plugin" then.

Contributor

robert-ancell commented Jun 10, 2020

I actually linked in the wrong API call there, that's the low level API but we should use gtk_show_uri_on_window(). That can connect the window to the app (though I don't know how many apps make use of it). We can still use g_app_info_get_default_for_uri_scheme for canLaunch. So it would have to be a full plugin and not use FFI.

Contributor Author

stuartmorgan commented Jun 10, 2020

That can connect the window to the app

I'm not sure we want that; the behavior on all the other platforms is that it fully switches to that application.

Contributor

robert-ancell commented Jun 10, 2020 •

edited

That can connect the window to the app

I'm not sure we want that; the behavior on all the other platforms is that it fully switches to that application.

I don't mean it embeds the window, but it passes the window (i.e. XID/Wayland handle) as part of the launch context. I think the intention is for this information to be provided to the window manager to help with focus stealing and window placement.

stuartmorgan added a commit to flutter/plugins that referenced this issue


          [url_launcher] Endorse url_launcher_linux (#2863)

8db69f3

Adds an endorsement for url_launcher_linux, so that Linux is supported
automatically.

Part of flutter/flutter#41721

stuartmorgan mentioned this issue

Add Windows support to url_launcher plugin #61051

Closed

agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this issue


          [url_launcher_linux] Add Linux url_launcher plugin (flutter#2857)

aab0f1b

Adds url_launcher_linux, the federated implementation of url_launcher.

Not yet endorsed by url_launcher

Part of flutter/flutter#41721

agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this issue


          [url_launcher] Endorse url_launcher_linux (flutter#2863)

b5cd5bd

Adds an endorsement for url_launcher_linux, so that Linux is supported
automatically.

Part of flutter/flutter#41721

ferrazrx added a commit to ferrazrx/plugins that referenced this issue


          [url_launcher_linux] Add Linux url_launcher plugin (flutter#2857)

39ba0ae

Adds url_launcher_linux, the federated implementation of url_launcher.

Not yet endorsed by url_launcher

Part of flutter/flutter#41721

ferrazrx added a commit to ferrazrx/plugins that referenced this issue


          [url_launcher] Endorse url_launcher_linux (flutter#2863)

7391c73

Adds an endorsement for url_launcher_linux, so that Linux is supported
automatically.

Part of flutter/flutter#41721

gspencergoog unassigned robert-ancell

gspencergoog removed platform-linux platform-mac labels

gspencergoog changed the title ~~[url_launcher] Add desktop support~~ [url_launcher] Add desktop support on Windows

csells moved this from To do to In progress in Windows Preview

stuartmorgan self-assigned this

stuartmorgan added this to the 1.23 - September 2020 milestone

stuartmorgan changed the title ~~[url_launcher] Add desktop support on Windows~~ [url_launcher] Add desktop support

stuartmorgan mentioned this issue

Add url_launcher_windows flutter/plugins#3015

Merged

13 tasks

stuartmorgan added a commit to flutter/plugins that referenced this issue


          Add url_launcher_windows (#3015)

c194de2

Adds a federated Windows implementation of url_launcher (not yet endorsed).

Since this is the first C++ plugin, this also adds a .clang-format file to the repo root for formatting C++ plugins.

Part of flutter/flutter#41721 (will need follow-up to endorse it in url_launcher)

stuartmorgan mentioned this issue

[url_launcher] Endorse Windows implementation flutter/plugins#3024

Merged

13 tasks

stuartmorgan moved this from In progress to In review in Windows Preview

stuartmorgan closed this as completed in flutter/plugins#3024

Windows Preview automation moved this from In review to Done

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this issue


          Add url_launcher_windows (flutter#3015)

b6c33d7

Adds a federated Windows implementation of url_launcher (not yet endorsed).

Since this is the first C++ plugin, this also adds a .clang-format file to the repo root for formatting C++ plugins.

Part of flutter/flutter#41721 (will need follow-up to endorse it in url_launcher)

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this issue


          [url_launcher_linux] Add Linux url_launcher plugin (flutter#2857)

0f4a0b3

Adds url_launcher_linux, the federated implementation of url_launcher.

Not yet endorsed by url_launcher

Part of flutter/flutter#41721

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this issue


          [url_launcher] Endorse url_launcher_linux (flutter#2863)

a667c99

Adds an endorsement for url_launcher_linux, so that Linux is supported
automatically.

Part of flutter/flutter#41721

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this issue


          Add url_launcher_windows (flutter#3015)

Adds a federated Windows implementation of url_launcher (not yet endorsed).

Since this is the first C++ plugin, this also adds a .clang-format file to the repo root for formatting C++ plugins.

Part of flutter/flutter#41721 (will need follow-up to endorse it in url_launcher)

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this issue


          [url_launcher_linux] Add Linux url_launcher plugin (flutter#2857)

39c45f6

Adds url_launcher_linux, the federated implementation of url_launcher.

Not yet endorsed by url_launcher

Part of flutter/flutter#41721

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this issue


          [url_launcher] Endorse url_launcher_linux (flutter#2863)

9b74c38

Adds an endorsement for url_launcher_linux, so that Linux is supported
automatically.

Part of flutter/flutter#41721

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this issue


          Add url_launcher_windows (flutter#3015)

338f64b

Adds a federated Windows implementation of url_launcher (not yet endorsed).

Since this is the first C++ plugin, this also adds a .clang-format file to the repo root for formatting C++ plugins.

Part of flutter/flutter#41721 (will need follow-up to endorse it in url_launcher)

github-actions bot commented Aug 12, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

github-actions bot locked as resolved and limited conversation to collaborators

flutter-triage-bot bot added the package label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.