Implement PlatformView support on macOS

[stuartmorgan]

We'll want to support embedding native views in a Flutter view, as is currently supported on mobile.

Remaining tasks:

• Gesture support
• Focus traversal
• Accessibility tree merging

[blasten]

@stuartmorgan we should chat. There's some opportunity to refactor the existing implementation on iOS, and I wonder if some code could be shared.

[stuartmorgan]

I suspect not—on the Flutter end macOS uses embedder.h and iOS doesn't, while on the native end Cocoa and CocoaTouch are similarly but entirely disjoint—but it's certainly worth investigating to find out for sure.

[radvansky-tomas]

So basically there is currently no option to create plugins which support native views - and then enable things like Google Maps, etc..

[vanlooverenkoen]

Isn't this something that should be implemented before we can speak of a stable desktop release? I can imagine that a lot of apps require some native views, video player, webview, maps,...

[stuartmorgan]

Conversely, lots of apps don't require those things; "stable" doesn't mean "has every feature that should eventually be supported" or "supports every use case".

Flutter 1.0, notably, did not support platform views.

[vanlooverenkoen]

Good to know. Is there some kind of roadmap for this? We are building a video streaming app for android, iOS, web, androidtv, tizen, webOS and we want to support desktop apps as well. But I think as long as this is not yet implemented in flutter there is no way to add support for desktop apps.

[radvansky-tomas]

But isnt PlatformView exactly tool for those features which are NOT supported yet ? so we can use existing OS features / plugins ? I mean having PlatformView ready before actually release of macOSX support seem to be quite essential.

Anyway I am looking forward for new features added to mac osx package

[vanlooverenkoen]

@radvansky-tomas platform channels are supported. The platform views are missing. So you add support for notifications on desktop. But video streaming, google maps (platform views) are not yet supported

[bdlukaa]

But video streaming, google maps (platform views) are not yet supported

I guess these are supported through a Texture widget, which, according to #30717 and flutter/engine#8507, are supported

[caojianfeng]

Lots of apps have features with WebView and VideoPlayer.
So they are very base features .

[kanekv]

This has a priority of P4, does it mean there is no hope to see it any time soon?

[stuartmorgan]

This has a priority of P4, does it mean there is no hope to see it any time soon?

It means that it's higher priority than the default for feature requests, but not currently on the Flutter team's short-term roadmap.

That doesn't mean it couldn't be implemented soon. Flutter is open-source, and anyone is welcome to pick up from where flutter/engine#22905 left off to contribute an implementation if they feel strongly about having it done sooner.

[knopp]

The NSView size should mirror the size of AppKitView. Can you provide a reproducible example?

[zhuhaichao518]

It's hard for us to provide a sample. I was just wondering if you have any context. We may debug it in the future. Thank you for your fast reply! Matej Knopp ***@***.***> 于2023年9月14日周四 19:56写道：

…

The NSView size should mirror the size of AppKitView. Can you provide a reproducible example? — Reply to this email directly, view it on GitHub <#41722 (comment)> or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM4EALGARMYAOVKPMK3EUA3X2LWH5BFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDQMZUG44TEMZVURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMZUGY3TGNZVHA4KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJHE4TSOJXGYYTEMFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCMRWGQ4DAMJRGQYKI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGIYDSNRYGAYTKMBSURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNJXGA3DGNRYGI3DRJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOMIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVAZTCNZZGI4DENECUR2HS4DFUVUXG43VMWSXMYLMOVS2SNJQGEYDKMZUGA3IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVEZDQMZUG44TEMZVQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGQ3DOMZXGU4DRAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTSOJZHE3TMMJSGCBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGEZDMNBYGAYTCNBQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGA4TMOBQGE2TAMUCUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNJXGA3DGNRYGI3DRJ3UOJUWOZ3FOKTGG4TFMF2GK> . You are receiving this email because you commented on the thread. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .

[amdshrif]

This has a priority of P4, does it mean there is no hope to see it any time soon?

It means that it's higher priority than the default for feature requests, but not currently on the Flutter team's short-term roadmap.

That doesn't mean it couldn't be implemented soon. Flutter is open-source, and anyone is welcome to pick up from where flutter/engine#22905 left off to contribute an implementation if they feel strongly about having it done sooner.

@stuartmorgan I would like to contribute and implement the needed support here but I need guidance and help to better understand the effort and how to add the support needed. Let me know if you could help me with that, thanks.

[cbracken]

@zhuhaichao518 if you can author a reduced reproduction that demonstrates the bug, then please file a new issue so we can take a look into it. That way we can keep this issue focused on missing features (input events, gestures, a11y, focus traversal), rather than bugs with what's already landed (visual rendering/composition, clipping, transforms, etc.)

[cbracken]

@amdshrif @knopp already has work in progress for some of the input event related side of things. Focus traversal and a11y wiring are both gaps. I'm currently working on a11y support.

[renanyoy]

I'm trying mac platform view, displaying some MTKView child in simple NSVIew, I have the flutter UI blinking sometime.

https://pub.waves.pw/ms/aestesis.mp4

[knopp]

I'm trying mac platform view, displaying some MTKView child in simple NSVIew, I have the flutter UI blinking sometime.

https://pub.waves.pw/ms/aestesis.mp4

That looks like the contents was not rendered in time but it got presented anyway. Possibly.

[knopp]

I'm trying mac platform view, displaying some MTKView child in simple NSVIew, I have the flutter UI blinking sometime.

https://pub.waves.pw/ms/aestesis.mp4

If you can provide a reproducible example (attached to a new issue) I will take a look.

[renanyoy]

@knopp thank you, I'm preparing an example

[renanyoy]

@knopp I managed to reproduce it, I filled a new issue #138936

[flutter-triage-bot]

This issue is assigned to @cbracken but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

[stuartmorgan]

Please see https://github.com/flutter/flutter/wiki/Issue-hygiene#when-will-my-bug-be-fixed and https://github.com/flutter/flutter/wiki/Issue-hygiene#do-not-add-me-too-or-same-or-is-there-an-update-comments-to-bugs before commenting here.

[ekuleshov]

@stuartmorgan @cbracken this issue is linked from the 2024 roadmap but I wasn't been able to find any specific tasks related to this work, e.g. a list of gaps or outstanding issues that need to be completed before this gets real. Do you have any hints on that?

[stuartmorgan]

@cbracken Do you want to edit the original issue description to include a checklist of the remaining items (e.g., gesture support) so it stays pinned to a discoverable location?

[cbracken]

Done!