Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderIntrinsicHeight should be more graceful when its child has an infinite intrinsic height #4175

Open
Hixie opened this issue May 25, 2016 · 0 comments
Open

RenderIntrinsicHeight should be more graceful when its child has an infinite intrinsic height #4175

Hixie opened this issue May 25, 2016 · 0 comments
Labels
a: error message Error messages from the Flutter framework c: crash Stack traces logged to the console c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@Hixie
Copy link
Contributor

Hixie commented May 25, 2016

Specifically, it should complain that that's a violation of the intrinsic height protocol, and try to pin point which class messed up.

(ditto widths)
@Hixie Hixie added affects: dev experience c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. labels May 25, 2016
@Hixie Hixie added this to the Flutter 1.0 milestone May 25, 2016
@Hixie Hixie modified the milestones: 3: Make conferences happy, 5: Make Hixie proud Jan 30, 2017
@Hixie Hixie modified the milestones: 3: Current Milestone, No milestone necessary Oct 17, 2017
@Hixie Hixie added the c: crash Stack traces logged to the console label Oct 17, 2017
@Hixie Hixie modified the milestones: No milestone necessary, 5: Make Hixie proud Oct 17, 2017
cdotstout pushed a commit to cdotstout/flutter that referenced this issue Apr 3, 2018
@cbracken
Revert "Use iOS scale when computing render buffer size (flutter#4171)…
459f722 
…" (flutter#4175)

This reverts commit d43d353.

Clear regression to the flutter_gallery_ios__transition_perf benchmarks:
  * average_frame_build_time_millis: 1.4x
  * missed_frame_build_budget_count: 1.2x

No regression seen for other iOS benchmarks (e.g. scrolling).
@Piinks Piinks added the a: error message Error messages from the Flutter framework label Nov 11, 2019
@Hixie Hixie modified the milestones: Stretch Goals, New Stretch Goals Jan 7, 2020
@kf6gpe kf6gpe added the P3 Issues that are less important to the Flutter project label May 29, 2020
@kf6gpe kf6gpe modified the milestone: Stretch Goals Jun 1, 2020
@Hixie Hixie removed this from the [DEPRECATED] Stretch Goals milestone Jun 16, 2020
@kf6gpe kf6gpe removed this from the [DEPRECATED] Stretch Goals milestone Jul 7, 2020
@kf6gpe kf6gpe modified the milestone: [DEPRECATED] Stretch Goals Jul 22, 2020
@Hixie Hixie removed this from the - milestone Aug 17, 2020
@jimbo-jones1313 jimbo-jones1313 mentioned this issue Mar 9, 2023
Closed
@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: error message Error messages from the Flutter framework c: crash Stack traces logged to the console c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hixie @kf6gpe @Piinks