Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tool]Analytics reporting state is not updated on user branch #45369

Closed
jonahwilliams opened this issue Nov 22, 2019 · 5 comments
Closed

[Tool]Analytics reporting state is not updated on user branch #45369

jonahwilliams opened this issue Nov 22, 2019 · 5 comments
Labels
tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@jonahwilliams
Copy link
Member

jonahwilliams-macbookpro2:flutter_tools jonahwilliams$ flutter config --no-analytics
Analytics reporting disabled.

You may need to restart any open editors for them to read new settings.
jonahwilliams-macbookpro2:flutter_tools jonahwilliams$ flutter config
Configure Flutter settings.

To remove a setting, configure it to an empty string.

The Flutter tool anonymously reports feature usage statistics and basic crash reports to help improve Flutter tools over time. See Google's privacy policy: https://www.google.com/intl/en/policies/privacy/

Usage: flutter config [arguments]
-h, --help                                    Print this usage information.
    --[no-]analytics                          Enable or disable reporting anonymously tool usage statistics and crash reports.
    --clear-ios-signing-cert                  Clear the saved development certificate choice used to sign apps for iOS device deployment.
    --android-sdk                             The Android SDK directory.
    --android-studio-dir                      The Android Studio install directory.
    --build-dir=<out/>                        The relative path to override a projects build directory
    --[no-]enable-web                         Enable or disable Flutter for web. This setting will take effect on the master and dev channels.
    --[no-]enable-linux-desktop               Enable or disable Flutter for desktop on Linux. This setting will take effect on the master channel.
    --[no-]enable-macos-desktop               Enable or disable Flutter for desktop on macOS. This setting will take effect on the master channel.
    --[no-]enable-windows-desktop             Enable or disable Flutter for desktop on Windows. This setting will take effect on the master channel.
    --[no-]enable-build-plugin-as-aar         Enable or disable Build plugins independently as AARs in app projects. This setting will take effect on the master channel.
    --[no-]enable-android-embedding-v2        Enable or disable flutter create generates projects using the Android embedding V2. This setting will take effect on the master channel.
    --[no-]enable-web-incremental-compiler    Enable or disable Enable the incremental compiler for web builds. This setting will take effect on the master and dev channels.
    --clear-features                          Remove all configured features and restore them to the default values.

Run "flutter help" to see global options.

Settings:
  flutter-web: true
  flutter-linux-desktop: true
  enable-web: true
  enable-macos-desktop: true
  ios-signing-cert: iPhone Developer: Jonah Williams (87UWLUA5U2)
  enable-web-incremental-compiler: false

Analytics reporting is currently enabled.

Afterwards:

{
  "flutter-web": true,
  "flutter-linux-desktop": true,
  "enable-web": true,
  "enable-macos-desktop": true,
  "ios-signing-cert": "iPhone Developer: Jonah Williams (....)",
  "enable-web-incremental-compiler": false
}
@jonahwilliams jonahwilliams added tool Affects the "flutter" command-line tool. See also t: labels. ⚠ TODAY labels Nov 22, 2019
@jonahwilliams jonahwilliams self-assigned this Nov 22, 2019
@jonahwilliams
Copy link
Member Author

False alarm! We have disabled analytics reporting for user branches, but as a result of this the flag does not get updated until you switch to a real branch. We should probably update this to still perist the setting, but it isn't as severe.

@jonahwilliams jonahwilliams changed the title Analytics reporting cannot be disabled Analytics reporting cannot be disabled from user branch Nov 22, 2019
@jonahwilliams jonahwilliams changed the title Analytics reporting cannot be disabled from user branch Analytics reporting state is updated from user branch Nov 22, 2019
@jonahwilliams jonahwilliams changed the title Analytics reporting state is updated from user branch Analytics reporting state is no updated on user branch Nov 22, 2019
@jonahwilliams jonahwilliams changed the title Analytics reporting state is no updated on user branch Analytics reporting state is not updated on user branch Nov 22, 2019
@jonahwilliams jonahwilliams removed their assignment Nov 22, 2019
@zoeyfan zoeyfan changed the title Analytics reporting state is not updated on user branch [Tool]Analytics reporting state is not updated on user branch Jan 9, 2020
@jmagman jmagman added this to Awaiting triage in Tools - metrics review via automation Jan 10, 2020
@zanderso zanderso moved this from Awaiting triage to Engineer reviewed in Tools - metrics review Feb 11, 2020
@zanderso
Copy link
Member

Updating the analytics flag on a user branch is a bit tricky to support without punching holes in package:usage. We should instead consider an error message like "Not updating analytics settings because you are on a local branch. Switch to master/dev/beta/stable and try again".

@braderyq

This comment has been minimized.

@jonahwilliams
Copy link
Member Author

Fixed via #71728

@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
Tools - metrics review
  
Engineer reviewed
Development

No branches or pull requests

3 participants