Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leaks in fml/platform/darwin #46750

Closed
cyanglaz opened this issue Dec 11, 2019 · 3 comments
Closed

Memory leaks in fml/platform/darwin #46750

cyanglaz opened this issue Dec 11, 2019 · 3 comments
Assignees
@cyanglaz
Labels
a: platform-views Embedding Android/iOS views in Flutter apps engine flutter/engine repository. See also e: labels. platform-ios iOS applications specifically
Milestone
March 2020

Comments

@cyanglaz
Copy link
Contributor

cyanglaz commented Dec 11, 2019 •
edited
Loading

Some objc objects are not released in this file. We need to fix those to avoid leaks.

One example would be CAShapeLayer* clip = [[CAShapeLayer alloc] init]; is never released.

We should use fml::CFRef for all CoreFoundation objects.
@cyanglaz cyanglaz mentioned this issue Dec 11, 2019
Merged
@cyanglaz cyanglaz changed the title Memory leaks in FlutterPlatformViews_Internal.mm Memory leaks in fml/platform/darwin Dec 11, 2019
@cyanglaz cyanglaz self-assigned this Dec 11, 2019
@cyanglaz cyanglaz added a: platform-views Embedding Android/iOS views in Flutter apps e: embedder Users of the Embedder API engine flutter/engine repository. See also e: labels. platform-ios iOS applications specifically and removed engine flutter/engine repository. See also e: labels. e: embedder Users of the Embedder API labels Dec 11, 2019
@cyanglaz cyanglaz added this to the March 2020 milestone Dec 11, 2019
@zhongwuzw
Copy link
Member

flutter/engine#14326
flutter/engine#14275

@zhongwuzw zhongwuzw mentioned this issue Dec 11, 2019
Merged
cbracken pushed a commit to flutter/engine that referenced this issue Dec 18, 2019
@zhongwuzw @cbracken
Fixes Objective-C objects memory leaks (#14326)
9c1bd8a 
Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750
@zhongwuzw zhongwuzw mentioned this issue Dec 22, 2019
Merged
This was referenced Dec 30, 2019
Merged
Merged
Merged
@kf6gpe kf6gpe added a: platform-views Embedding Android/iOS views in Flutter apps and removed a: platform-views Embedding Android/iOS views in Flutter apps labels Jan 6, 2020
cbracken pushed a commit to flutter/engine that referenced this issue Jan 24, 2020
@zhongwuzw @cbracken
Fixes FlutterCallbackInfomation leaks (#15089)
45fe095 
See: flutter/flutter#46750
@cyanglaz
Copy link
Contributor Author

This seems to be fixed, closing the issue.

NoamDev pushed a commit to NoamDev/engine that referenced this issue Feb 27, 2020
@zhongwuzw @NoamDev
Fixes FlutterCallbackInfomation leaks (flutter#15089)
b610694 
See: flutter/flutter#46750
Partizann pushed a commit to Partizann/engine that referenced this issue Mar 10, 2020
@zhongwuzw
Fixes Objective-C objects memory leaks (flutter#14326)
91c813b 
Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750
filmil pushed a commit to filmil/engine that referenced this issue Mar 13, 2020
@zhongwuzw @filmil
Fixes Objective-C objects memory leaks (flutter#14326)
a11abf1 
Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cyanglaz cyanglaz

Labels
a: platform-views Embedding Android/iOS views in Flutter apps engine flutter/engine repository. See also e: labels. platform-ios iOS applications specifically
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@kf6gpe @cyanglaz @zhongwuzw