General improvements to theming

[jamiethain]

Currently the Themeing system is difficult to use and understand.

For example what theme is applied to what? I just want to set the AppBar Text

I want to set every property in the application when using Theme's. How do we do this. It needs to be extremely well documented.

I found this in App Bar, that centerStyle was used to set title.

TextStyle centerStyle = widget.textTheme?.title
      ?? appBarTheme.textTheme?.title
      ?? theme.primaryTextTheme.title;

And I set appBarTheme.textTheme.title to white and I still get black.

Themeing is extremely difficult in Flutter.

[iapicca]

Hi @jamiethain
could you please details the issue more in dept?
Are you indicating that something isn't working as intended
or you are advancing a proposal,
if the latter is the case could you please describe it in detail?
thank you

[HansMuller]

I would definitely appreciate the additional info that @iapicca asked for. However it's agreed that much of theme system is difficult to understand and apply. We're working on a broad proposal to address the issue. Look for it early next year.

[jamiethain]

Hans, I have a deadline for Thursday, and after that i will give a full write up, But i will do a few quick ideas here, chipCard colors are almost impossible to figure out. The chipCardTheme needs to have better variables like, new InkThemeData( tdl : ThemeData( primaryColor: Color(0xffDAEAEF), accentColor: Color(0x823852), cardColor: Color(0xffe5e5e5), brightness: Brightness.light, buttonTheme: ButtonThemeData(buttonColor: Color(0xfffffff) ), dividerColor: Color(0x6DAEAEF), floatingActionButtonTheme: FloatingActionButtonThemeData( foregroundColor: Colors.white, // backgroundColor: FanColors.fanMaterialButtons ), dividerTheme: DividerThemeData(color: Color(0xffDAEAEF ), thickness: 1, space: 4 ), fontFamily: 'OpenSans' ), AppBarLogo: "", chipColorSelectedText: Colors.white, chipColorUnSelectedText: Colors.black, chipColorSelected: Colors.blue, // chipColorUnselected: Colors.blue, I literally built an extended Themeing system where in my Code I use objects and specifically name colors. So I agree ChipTheme should be an object but the colors in there should be the ones above. I will put more effort into it soon. JAmie

…

On Tue, Dec 17, 2019, 11:56 AM Hans Muller ***@***.***> wrote: I would definitely appreciate the additional info that @iapicca <https://github.com/iapicca> asked for <#47166 (comment)>. However it's agreed that the much of theme system is difficult to understand and apply. We're working on a broad proposal to address the issue. Look for it early next year. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47166?email_source=notifications&email_token=AMOCL6DJVPL75WV3SJS6X3LQZEAEXA5CNFSM4J3S3CZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHDGZAY#issuecomment-566652035>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMOCL6EJV6SMNGQJ45GIOZLQZEAEXANCNFSM4J3S3CZA> .

[HansMuller]

@jamiethain - Sorry, I'd forgotten to update this issue. Early this year we published an outline of the Theme related work we're planning: flutter.dev/go/material-theme-system-updates. The overall goal is to make the theme system easier to understand and apply. Because the button theme system is in the worst shape (in terms of usability), we've been focusing on that at the outset, see flutter.dev/go/material-button-system-updates and #54776.

[jamiethain]

Hans, Thanks for this -- we basically have made our own "theme work-arounds" of things that we do a lot and store them in JSON format. What ever solution you come up with, we would appreciate ThemeToJSON and JSONToTheme so we can store them in other places than directly in the code. We are writing our own ThemeToJson, JsonToTheme as we we speak using the old theme libraries. Kind regards, Jamie

…

On Mon, May 11, 2020 at 11:41 AM Hans Muller ***@***.***> wrote: @jamiethain <https://github.com/jamiethain> - Sorry, I'd forgotten to update this issue. Early this year we published an outline of the Theme related work we're planning: flutter.dev/go/material-theme-system-updates. The overall goal is to make the theme system easier to understand and apply. Because the button theme system is in the worst shape (in terms of usability), we've been focusing on that at the outset, see flutter.dev/go/material-button-system-updates and #54776 <#54776>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47166 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMOCL6AXGR23XV2SX6HOHGTRRAMENANCNFSM4J3S3CZA> .