Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web][edge] run history_test.dart on Safari #51169

Closed
nturgut opened this issue Feb 21, 2020 · 1 comment · Fixed by flutter/engine#41901
Closed

[web][edge] run history_test.dart on Safari #51169

nturgut opened this issue Feb 21, 2020 · 1 comment · Fixed by flutter/engine#41901
Labels
a: tests "flutter test", flutter_test, or one of our tests browser: safari-macos only manifests in Safari on macOS c: flake Tests that sometimes, but not always, incorrectly pass framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
Web Engine Tests in Multiple Browsers

Comments

@nturgut
Copy link
Contributor

nturgut commented Feb 21, 2020

history_test.dart test was not failing for Safari/MacOS on the other hand, taking a long time on LUCI:

Example run: https://chromium-swarm.appspot.com/task?id=4a7ed7b6ce5a3910

This test passes locally. Try on a Mac machine:

felt test --browser=safari
@nturgut nturgut added the platform-web Web applications specifically label Feb 21, 2020
@nturgut nturgut added this to the Near-term Goals milestone Feb 21, 2020
@nturgut nturgut added this to TODO in Web Engine Tests in Multiple Browsers via automation Feb 21, 2020
@kf6gpe kf6gpe added the P1 High-priority issues at the top of the work list label May 29, 2020
@yjbanov yjbanov added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Jun 16, 2020
@iapicca iapicca added a: tests "flutter test", flutter_test, or one of our tests browser: safari-macos only manifests in Safari on macOS framework flutter/packages/flutter repository. See also f: labels. labels Jul 6, 2020
@kf6gpe kf6gpe modified the milestone: [DEPRECATED] Near-term Goals Jul 7, 2020
@kf6gpe kf6gpe removed this from the [DEPRECATED] Near-term Goals milestone Jul 22, 2020
@Hixie Hixie removed this from the None milestone Aug 17, 2020
@markusaksli-nc markusaksli-nc added passed first triage team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Sep 21, 2020
@mdebbar mdebbar mentioned this issue May 10, 2023
Merged
Web Engine Tests in Multiple Browsers automation moved this from TODO to Done May 10, 2023
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 10, 2023
@mdebbar
[web] Re-enable history tests on Safari (#41901)
406b354 
Fixes flutter/flutter#51169
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
@flutter-triage-bot flutter-triage-bot bot added the c: flake Tests that sometimes, but not always, incorrectly pass label Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests browser: safari-macos only manifests in Safari on macOS c: flake Tests that sometimes, but not always, incorrectly pass framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
Web Engine Tests in Multiple Browsers
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[web] Re-enable history tests on Safari mdebbar/engine
6 participants
@yjbanov @Hixie @kf6gpe @iapicca @nturgut @markusaksli-nc