Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gen_l10n] Tool should output files that were read and written #55503

Closed
shihaohong opened this issue Apr 23, 2020 · 3 comments · Fixed by #56490
Closed

[gen_l10n] Tool should output files that were read and written #55503

shihaohong opened this issue Apr 23, 2020 · 3 comments · Fixed by #56490
Assignees
Labels
a: internationalization Supporting other languages or locales. (aka i18n)

Comments

@shihaohong
Copy link
Contributor

This allows for developers and tools dependent on the gen_l10n workflow to verify which files were needed and created by the tool.

In particular, this would be helpful for Flutter tool integration of the gen_l10n workflow (see 277b2fd), since the tool would currently have to makes guesses on whether or not gen_l10n needs to be rerun.

cc/ @HansMuller @jonahwilliams

@shihaohong
Copy link
Contributor Author

@jonahwilliams I was thinking of making this feature optional so we do not generate too many unnecessary files for our users, but it has to be required in order for the incremental build system that we're using for the integration tool right?

@jonahwilliams
Copy link
Member

Optional is fine, we would like specify the location where they are written into a hidden directory somewhere.

Without this, we need to guess the output files. I don't really want to do that because If I guess wrong then things don't rebuilt correcty

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: internationalization Supporting other languages or locales. (aka i18n)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants