Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an always true BotDetector in fuchsia_asset_builder.dart #58740

Open
zanderso opened this issue Jun 5, 2020 · 0 comments
Open

Use an always true BotDetector in fuchsia_asset_builder.dart #58740

zanderso opened this issue Jun 5, 2020 · 0 comments
Labels
a: quality A truly polished experience customer: fuchsia P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@zanderso
Copy link
Member

zanderso commented Jun 5, 2020

The fuchsia_asset_builder tool runs during the Fuchsia build, and should never not be considered a bot. Analytics is already disabled for the entrypoint, but bot detection runs beforehand. Running the real bot detector is likely resulting in stray files in the Fuchsia source tree. This can be worked around by injecting a bot detector that always returns true here:

Example hardwired bot detector:

class AlwaysTrueBotDetector implements BotDetector {

/cc @iskakaushik @jonahwilliams

@zanderso zanderso added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. customer: fuchsia tool Affects the "flutter" command-line tool. See also t: labels. a: quality A truly polished experience labels Jun 5, 2020
@zanderso zanderso changed the title Use and always true BotDetector in fuchsia_asset_builder.dart Use an always true BotDetector in fuchsia_asset_builder.dart Jun 5, 2020
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label Jun 8, 2020
@jmagman jmagman added this to Awaiting triage in Tools - Fuchsia review via automation Jun 9, 2020
@zanderso zanderso moved this from Awaiting triage to Engineer reviewed in Tools - Fuchsia review Aug 5, 2020
@flutter-triage-bot flutter-triage-bot bot added team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: quality A truly polished experience customer: fuchsia P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
Tools - Fuchsia review
  
Engineer reviewed
Development

No branches or pull requests

4 participants