Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] argument name should be transferred to the generated class #58910

Closed
xster opened this issue Jun 7, 2020 · 4 comments
Closed

[pigeon] argument name should be transferred to the generated class #58910

xster opened this issue Jun 7, 2020 · 4 comments
Assignees
Labels
p: pigeon related to pigeon messaging codegen tool P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels.

Comments

@xster
Copy link
Member

xster commented Jun 7, 2020

I started with

@HostApi()
abstract class HostBookApi {
  void finishedEditingBook(Book book);
}

ended Java/Kotlin:

override fun finishedEditingBook(arg: Api.Book?) {
}

Dart:

@override
void displayBookDetails(Book arg) {
}
@xster xster added the package flutter/packages repository. See also p: labels. label Jun 7, 2020
@xster xster added the p: pigeon related to pigeon messaging codegen tool label Sep 24, 2020
@xster
Copy link
Member Author

xster commented Apr 15, 2021

Here's another hopefully simple one. But it is a breaking change so when we do it, we should move the version to 0.3 and add a breaking change note.

@stuartmorgan
Copy link
Contributor

@gaaclarke Was this fixed during the arity changes?

@stuartmorgan stuartmorgan added the P2 Important issues not at the top of the work list label Oct 26, 2021
@gaaclarke
Copy link
Member

Yep, this got fixed. The argument will now be called "bookArg". It was introduced in 8ea7bec.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: pigeon related to pigeon messaging codegen tool P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels.
Projects
None yet
Development

No branches or pull requests

5 participants