Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current values are missing from RangeSliderThumbShape paint() method #62486

Open
Tracked by #125329
njustin opened this issue Jul 29, 2020 · 5 comments · Fixed by NevercodeHQ/flutter#1
Open
Tracked by #125329

Current values are missing from RangeSliderThumbShape paint() method #62486

njustin opened this issue Jul 29, 2020 · 5 comments · Fixed by NevercodeHQ/flutter#1
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@njustin
Copy link

njustin commented Jul 29, 2020

Use case

I want to customise a RangeSlider Thumb by adding the current value in the thumb.
It is possible with the SliderThumbShape class, since the paint() method is also passing the current value as the value parameter.
Please note that the RangeSliderValueIndicatorShape also include this value parameter.
So it seems like an incoherency in the API.

Proposal

Add the value (or values) parameter to the paint() method of RangeSliderThumbShape.
Please see #39882 which already added this parameter but sadly the issue was automatically closed...
@pedromassangocode pedromassangocode added easy fix f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: proposal A detailed proposal for a change to Flutter c: new feature Nothing broken; request for a new capability labels Jul 29, 2020
This was referenced Jul 29, 2020
Closed
Merged
@HansMuller
Copy link
Contributor

CC @clocksmith @JoseAlba

@TahaTesser TahaTesser reopened this Jul 30, 2020
@pedromassangocode pedromassangocode mentioned this issue Jul 30, 2020
Closed
9 tasks
@pedromassangocode
Copy link

This is being worked and will be closed by #62572.

@DustinJSilk
Copy link

Looks like that PR has been closed without the fix. Any updates on this?

@njustin
Copy link
Author

njustin commented Aug 24, 2020

Hi there!
The issue for me is not fixed in Flutter 1.20.2, despite some other breaking changes have been included on this paint method.
#62572 is closed but the commit does not seem to be in the master branch.

Maybe something is happening on another branch ?

@simon1990zcs
Copy link

Hi, I have synced to the latest flutter code, still couldn't find the current value in RangeSliderThumbShape, any update on this please?

@rydmike rydmike mentioned this issue Apr 21, 2023
Open
32 tasks
@TahaTesser TahaTesser self-assigned this May 4, 2023
@TahaTesser TahaTesser removed their assignment Jun 19, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-design Owned by Design Languages team triaged-design Triaged by Design Languages team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Milestone
No milestone
7 participants
@Hixie @njustin @HansMuller @DustinJSilk @simon1990zcs @TahaTesser @pedromassangocode