Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Rework Slider & RangeSlider widgets #125329

Open
6 of 32 tasks
rydmike opened this issue Apr 21, 2023 · 13 comments
Open
6 of 32 tasks

☂️ Rework Slider & RangeSlider widgets #125329

rydmike opened this issue Apr 21, 2023 · 13 comments
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@rydmike
Copy link
Contributor

rydmike commented Apr 21, 2023

☂️ Umbrella of Slider and RangeSlider issues

Rework the Slider & RangeSlider widgets to address most if not all issues listed below.


Slider

Callback issues

Value indicator

Thumb

Performance

Slider error issues

New feature and Proposals

Accessibility

Documentation

Tests

RangeSlider

Value indicator

New features and Proposals

Functionality

Accessibility

Slider Updates Project

https://github.com/orgs/flutter/projects/44/views/2

@TahaTesser TahaTesser added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 21, 2023
@TahaTesser TahaTesser self-assigned this Apr 21, 2023
@TahaTesser
Copy link
Member

TahaTesser commented Apr 21, 2023

A simple umbrella issue is effective and feels helpful in this case, since there are a large number of open issues related to sliders.

Agree! Thank you for creating this.

Edit:

I've removed the CupertinoSlider as it is not part of material and is very different in scope as well.

@TahaTesser TahaTesser changed the title ☂️ Collection of Slider, RangeSlider and CupertinoSlider Issues ☂️ Collection of Slider & RangeSlider issues Apr 21, 2023
@rydmike
Copy link
Contributor Author

rydmike commented Apr 22, 2023

Sure and agreed @TahaTesser. There were not so many of them anyway. While collectiong the list, I did notice that some of the issues did seem to have some overlap between Slider/RangeSlider and CupertinoSlider as well, but not many.

By the way, the CupertinoSlider has one of the features requested for Slider (#113370) out of the box. It actually only has the mode where you always have to slide the thumb, you can not click on the track to move the thumb. In some use cases I stoped using platform adaptive Slider.adaptive, as I did not like that for the use cases in question, even on iOS. I do agree with the feature request though, for some use cases it can be the other way around, that it is a requirement to have that behavior, then currently Slider is not a suitable.


Edit:
Confirmed the CupertinoSlider behavior, previous entry said it was just based on memory and that I was not 100% sure it behaved that way. Now verified this by testing it in repos where I still use Slider.adaptive.

@stuartmorgan
Copy link
Contributor

A simple umbrella issue is effective and feels helpful in this case, since there are a large number of open issues related to sliders.

This seems like it should be a label or project.

Our guidelines for issues are that they must be actionable, which means we should be able to describe the conditions under which the issue would be closed. What is that condition here?

@jmagman jmagman added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 27, 2023
@TahaTesser
Copy link
Member

A simple umbrella issue is effective and feels helpful in this case, since there are a large number of open issues related to sliders.

This seems like it should be a label or project.

Our guidelines for issues are that they must be actionable, which means we should be able to describe the conditions under which the issue would be closed. What is that condition here?

I'm doing a major rework on these two widgets under https://github.com/orgs/flutter/projects/44/views/2.
Perhaps a better title would be needed?

@TahaTesser TahaTesser changed the title ☂️ Collection of Slider & RangeSlider issues ☂️ Rework Slider & RangeSlider widgets Apr 27, 2023
@stuartmorgan
Copy link
Contributor

So the goal of the project is to fix every issue on this list? It's a much longer list than the project you linked to currently has.

It would help if the issue were updated to explain what the end state is; right now the text sounds like it's describing a list of every issue in a category rather than a work list for a bounded project.

@TahaTesser TahaTesser removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 27, 2023
@TahaTesser
Copy link
Member

TahaTesser commented Apr 28, 2023

So the goal of the project is to fix every issue on this list? It's a much longer list than the project you linked to currently has.

It would help if the issue were updated to explain what the end state is; right now the text sounds like it's describing a list of every issue in a category rather than a work list for a bounded project.

Updated description to cover areas of the widgets to be fixed and removed some out of scope engine related issues.

@rydmike
Copy link
Contributor Author

rydmike commented Apr 28, 2023

Thanks @TahaTesser, great improvements and clarifications to the collection.

I originally added this collection issue so I could figure what issues related to Slider and RangeSlider were already known, to be able to figure out if I should add new ones or not, for all the issues I had recorded as well. I found most of them pre-existing after I collected this list, I then added more input on some of the original issues.

I also found it helpful to be able to refer FlexColorScheme and Themes Playground users to a single collection, basically to inform them that for any Slider and RangeSlider related issues, please see this collection first.

I also knew about your Slider project, that you linked above, and thought it could be useful to have a list like this, just to double check if there might be some more issues related to the project, that might be suitable to address during it. Which I can see has been done as well. Excellent and thanks again 👍🏻

@dleyba042
Copy link
Contributor

@TahaTesser thanks for the reply. One quick question. I am part of a team in college trying to make some open source contributions. We were all going to try to contribute under this Umbrella issues since the issues are related and we could be working in the same area. Do you recommend us all to look elsewhere? Thanks for your time.

@Piinks
Copy link
Contributor

Piinks commented May 3, 2023

Hey @dleyba042 I am glad to hear about your group wanting to contribute! I would recommend starting with our contributing guide, it leads to other pages in the wiki with guidance on finding something to work on.
If you and the others would like to join the discord (instructions also in the wiki) and discuss some issues, feel free to ping me (same user name). :)

@TahaTesser
Copy link
Member

@dleyba042
Hi! Thanks for reaching out.

I am part of a team in college trying to make some open source contributions.

That sounds wonderful, I'd recommend taking a look at issues with good first contribution and easy fix labels.
https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+contribution%22
https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22easy+fix%22

Any issues with documentation labels are also great to get started.
https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Adocumentation
https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22d%3A+api+docs%22

@dleyba042
Copy link
Contributor

@Piinks Thanks for the info, I will pass that on, and I appreciate the offer for guidance on Discord!

@dleyba042
Copy link
Contributor

@TahaTesser thanks for your guidance, I appreciate it!

@hit-flutter
Copy link

Hello team,

Any update on this?
Some of these issues are very important to fix as they are basic functionality for the UI framework.

@HansMuller HansMuller added the P2 Important issues not at the top of the work list label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
Status: Todo
Development

No branches or pull requests

9 participants