Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement flutter/settings channel in Windows embedding #65590

Closed
stuartmorgan opened this issue Sep 10, 2020 · 1 comment · Fixed by flutter/engine#22323
Closed

Implement flutter/settings channel in Windows embedding #65590

stuartmorgan opened this issue Sep 10, 2020 · 1 comment · Fixed by flutter/engine#22323
Assignees
@stuartmorgan
Labels
a: desktop Running on desktop a: internationalization Supporting other languages or locales. (aka i18n) engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-windows Building on or for Windows specifically
Projects
Windows Beta

Comments

@stuartmorgan
Copy link
Contributor

As a starting point, we should be sending the user's preferred time format, for proper l10n/i18n handling.
@stuartmorgan stuartmorgan added engine flutter/engine repository. See also e: labels. platform-windows Building on or for Windows specifically a: desktop Running on desktop labels Sep 10, 2020
@stuartmorgan stuartmorgan added this to To do in Windows Beta via automation Sep 10, 2020
@stuartmorgan stuartmorgan added the a: internationalization Supporting other languages or locales. (aka i18n) label Sep 10, 2020
@gspencergoog gspencergoog added the P2 Important issues not at the top of the work list label Oct 14, 2020
@stuartmorgan stuartmorgan self-assigned this Nov 4, 2020
stuartmorgan added a commit to stuartmorgan/engine that referenced this issue Nov 5, 2020
@stuartmorgan
Add initial settings message to Windows embedding
9b0eb19 
Sends the flutter/settings update message to the engine after starting
it. For now values other than 24-hour time preference are hard-coded,
but dark mode support can be added later.

Fixes flutter/flutter#65590
@stuartmorgan stuartmorgan mentioned this issue Nov 5, 2020
Merged
10 tasks
@csells csells moved this from To do to In progress in Windows Beta Nov 10, 2020
Windows Beta automation moved this from In progress to Done Nov 23, 2020
stuartmorgan added a commit to flutter/engine that referenced this issue Nov 23, 2020
@stuartmorgan
Add initial settings message to Windows embedding (#22323)
9f207a3 
Sends the flutter/settings update message to the engine after starting
it. For now values other than 24-hour time preference are hard-coded,
but dark mode support can be added later.

Fixes flutter/flutter#65590
chaselatta pushed a commit to chaselatta/engine that referenced this issue Nov 30, 2020
@stuartmorgan @chaselatta
Add initial settings message to Windows embedding (flutter#22323)
2724e8b 
Sends the flutter/settings update message to the engine after starting
it. For now values other than 24-hour time preference are hard-coded,
but dark mode support can be added later.

Fixes flutter/flutter#65590
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan stuartmorgan

Labels
a: desktop Running on desktop a: internationalization Supporting other languages or locales. (aka i18n) engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-windows Building on or for Windows specifically
Projects
Windows Beta
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add initial settings message to Windows embedding stuartmorgan/engine
3 participants
@stuartmorgan @gspencergoog @pedromassangocode