Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake on RasterThreadMerger.RunExpiredTasksWhileFirstTaskUnMergesThreads #66922

Closed
iskakaushik opened this issue Sep 29, 2020 · 9 comments · Fixed by flutter/engine#26612
Closed

Flake on RasterThreadMerger.RunExpiredTasksWhileFirstTaskUnMergesThreads #66922

iskakaushik opened this issue Sep 29, 2020 · 9 comments · Fixed by flutter/engine#26612
Labels
c: flake Tests that sometimes, but not always, incorrectly pass engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list

Comments

@iskakaushik
Copy link
Contributor

See: https://ci.chromium.org/p/flutter/builders/prod/Linux%20Fuchsia/5598

cc: @lucasradaelli, @dnfield
iskakaushik pushed a commit to iskakaushik/engine that referenced this issue Sep 29, 2020
Revert "[fuchsia][a11y] Don't populate hidden state. (flutter#21484)"
49524d6 
This reverts commit 20be778.

See: flutter/flutter#66922
@iskakaushik iskakaushik mentioned this issue Sep 29, 2020
Closed
@iskakaushik iskakaushik added engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression labels Sep 29, 2020
@dnfield
Copy link
Contributor

dnfield commented Sep 29, 2020

This failure doesn't make sense for the linked commit. The linked commit was a change to a11y. The failure is in the RasterThreadMerger tests.

[ RUN      ] RasterThreadMerger.RunExpiredTasksWhileFirstTaskUnMergesThreads
../../flutter/fml/raster_thread_merger_unittests.cc:566: Failure
Expected equality of these values:
  fml::MessageLoop::GetCurrentTaskQueueId()
    Which is: 168
  qid_platform
    Which is: 167
[  FAILED  ] RasterThreadMerger.RunExpiredTasksWhileFirstTaskUnMergesThreads (0 ms)

@iskakaushik
Copy link
Contributor Author

The test failures seem like a flake. De-escalating to P3.

@iskakaushik iskakaushik added P1 High-priority issues at the top of the work list and removed P0 Critical issues such as a build break or regression labels Sep 29, 2020
@zanderso zanderso changed the title a11y changes broke Fuchsia unittests Flake on RasterThreadMerger.RunExpiredTasksWhileFirstTaskUnMergesThreads Mar 25, 2021
@zanderso
Copy link
Member

This happened again here https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20FEMU/3114/overview

@iskakaushik
Copy link
Contributor Author

happened again on: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Fuchsia%20FEMU/2780/overview

@dnfield
Copy link
Contributor

dnfield commented Jun 2, 2021

Seems like it's only happening on fuschia. /Cc @arbreng @chaselatta

@iskakaushik
Copy link
Contributor Author

Seen again: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8845516146557485760/+/u/FEMU_Test/Run_FEMU_Test_fml_tests/stdout

@arbreng
Copy link
Contributor

arbreng commented Jun 2, 2021

flutter/engine#26542 fixed this, but it should be reverted after flutter/engine#26193 lands

iskakaushik added a commit to iskakaushik/engine that referenced this issue Jun 7, 2021
@iskakaushik
Fix issues with RunExpiredTasksWhileFirstTaskUnMergesThreads
ef98eaa 
- The latch is count down 3 times
- after unmerge the thread should be raster thread

Fixes: flutter/flutter#66922
@iskakaushik iskakaushik mentioned this issue Jun 7, 2021
Merged
@zanderso
Copy link
Member

zanderso commented Jun 7, 2021 •
edited

It looks like this is still happening:

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20FEMU/4109/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20FEMU/4123/overview

ETA: Oh, I see flutter/engine#26612 is intended to address this and is still in progress. Thanks!

iskakaushik added a commit to iskakaushik/engine that referenced this issue Jun 7, 2021
@iskakaushik
Fix issues with RunExpiredTasksWhileFirstTaskUnMergesThreads
df4246b 
- The latch is count down 3 times
- after unmerge the thread should be raster thread

Fixes: flutter/flutter#66922
iskakaushik added a commit to iskakaushik/engine that referenced this issue Jun 7, 2021
@iskakaushik
Fix issues with RunExpiredTasksWhileFirstTaskUnMergesThreads
039e1f2 
- The latch is count down 3 times
- after unmerge the thread should be raster thread

Fixes: flutter/flutter#66922
iskakaushik added a commit to iskakaushik/engine that referenced this issue Jun 7, 2021
@iskakaushik
Fix issues with RunExpiredTasksWhileFirstTaskUnMergesThreads
b0cd27c 
- The latch is count down 3 times
- after unmerge the thread should be raster thread

Fixes: flutter/flutter#66922
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
@flutter-triage-bot flutter-triage-bot bot added the c: flake Tests that sometimes, but not always, incorrectly pass label Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: flake Tests that sometimes, but not always, incorrectly pass engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with RunExpiredTasksWhileFirstTaskUnMergesThreads iskakaushik/engine
5 participants
@iskakaushik @zanderso @dnfield @arbreng @TahaTesser