Federate the Android and iOS implementations of 1P plugins #68498

MisterJimson · 2020-10-19T17:37:09Z

Use case

From the flutter docs: https://flutter.dev/docs/development/packages-and-plugins/developing-packages#federated-plugins

Federated plugins are a a way of splitting support for different platforms into separate packages. So, a federated plugin can use one package for iOS, another for Android, another for web, and yet another for a car (as an example of an IoT device). Among other benefits, this approach allows a domain expert to extend an existing plugin to work for the platform they know best.

This seems at odds with the official plugins not having the Android and iOS implementations in separate projects.

Looking at shared_preferences as an example: https://github.com/flutter/plugins/tree/master/packages/shared_preferences

Why are web and desktop in separate packages but Android and iOS are not? If we want to swap the implementation of Android or iOS, the default implementation is still present. Why are they special?

Proposal

Treat all platforms the same, 1 package per platform.

Here is an example of what I am calling "fully federated", where there is no platform implementations in the app facing package: https://github.com/MisterJimson/federated_plugins_example/tree/fully-federated

The text was updated successfully, but these errors were encountered:

stuartmorgan · 2020-10-19T21:11:48Z

Why are web and desktop in separate packages but Android and iOS are not?

Because they predate federation.

Treat all platforms the same, 1 package per platform.

This is the plan of record. However, the work of transitioning existing plugin implementations has been low priority.

Patches federating existing mobile implementations would be welcome, and it's something that will get cleaned up at some point.

Sunbreak · 2021-08-14T05:08:47Z

Does it work out? woodemi/quick_flutter.brick#22 (comment)

Choice B: all implementations are in their own federated package

$ mason make quick_flutter_federated_plugin
...
$ ls fedplugin/
fedplugin			fedplugin_ios			fedplugin_macos			fedplugin_web
fedplugin_android		fedplugin_linux			fedplugin_platform_interface	fedplugin_windows

stuartmorgan · 2021-08-14T12:06:52Z

I'm not sure what you are asking. If it's "is it possible to implement what this issue describes", then yes.

Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure. Temporarily marks `path_provider` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. Part of flutter/flutter#68498

Now that the iOS and Android implementation packages are published, switch to them and re-enable publishing. Part of flutter/flutter#68498

Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure. Temporarily marks shared_preferences as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. Part of flutter/flutter#68498

Restores the app-facing package to publishable state, pointing at the newly-published federated Android and iOS implementation packages. Part of Part of flutter/flutter#68498

Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure. Temporarily marks `url_launcher` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. Part of flutter/flutter#68498

Restores the app-facing package to a publishable state now that _android and _ios implementation packages are published. Part of flutter/flutter#68498

Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure. Temporarily marks `path_provider` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. Part of flutter/flutter#68498

Now that the iOS and Android implementation packages are published, switch to them and re-enable publishing. Part of flutter/flutter#68498

Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure. Temporarily marks shared_preferences as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. Part of flutter/flutter#68498

Moves the iOS and Android implementations to their own federated packages. The iOS implementation package uses the name `avfoundation` rather than `ios` since it is likely that a macOS implementation could share a significant amount of code. As part of the federation, migrates the mobile implementations to using in-package method channels rather than the shared method channel. Currently these are just duplicates of the existing method channels; updating them to new version of Pigeon will be done in a separate PR later. Temporarily marks `video_player` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. No version change: The changes to `video_player_platform_interface` only affect development of the plugin, not use of the plugin. Part of flutter/flutter#68498 Part of flutter/flutter#94224

Publishes the change from in-package Android and iOS implementations to federated implementations. Part of flutter/flutter#68498

Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure. Temporarily marks `url_launcher` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. Part of flutter/flutter#68498

Restores the app-facing package to a publishable state now that _android and _ios implementation packages are published. Part of flutter/flutter#68498

stuartmorgan · 2022-03-22T14:14:11Z

Note: camera is blocked by #100555.

Restores the app-facing package to a publishable state, switch to the newly published federated mobile versions. Part of flutter/flutter#68498

Re-enables publishing of `camera` now that the mobile federated implementation packages have been published. Part of flutter/flutter#68498

Restored the app-facing package to publishable state, using the newly-published federated mobile implementations. Part of flutter/flutter#68498

github-actions · 2022-08-17T23:00:39Z

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

darshankawar added plugin c: proposal A detailed proposal for a change to Flutter labels Oct 20, 2020

stuartmorgan added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. P2 Important issues not at the top of the work list and removed c: proposal A detailed proposal for a change to Flutter labels May 21, 2021

stuartmorgan mentioned this issue May 21, 2021

Explain federal plugin structure better #83117

Closed

stuartmorgan added platform-android Android applications specifically platform-ios iOS applications specifically labels Jun 13, 2021

stuartmorgan mentioned this issue Nov 1, 2021

[path_provider] Federate mobile implementations flutter/plugins#4465

Merged

11 tasks

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Nov 10, 2021

[path_provider] Publish fully federated version

b1bb217

Now that the iOS and Android implementation packages are published, switch to them and re-enable publishing. Part of flutter/flutter#68498

This was referenced Nov 10, 2021

[path_provider] Publish fully federated version flutter/plugins#4497

Merged

[shared_preferences] Federate mobile implementations flutter/plugins#4505

Merged

stuartmorgan added a commit to flutter/plugins that referenced this issue Nov 13, 2021

[path_provider] Publish fully federated version (#4497)

8a95012

Now that the iOS and Android implementation packages are published, switch to them and re-enable publishing. Part of flutter/flutter#68498

stuartmorgan mentioned this issue Nov 16, 2021

[url_launcher] Federate mobile implementations flutter/plugins#4515

Merged

11 tasks

stuartmorgan mentioned this issue Nov 19, 2021

[shared_preferences] Publish fully federated version flutter/plugins#4526

Merged

11 tasks

stuartmorgan mentioned this issue Nov 23, 2021

[url_launcher] Publish fully federated version flutter/plugins#4536

Merged

11 tasks

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Feb 2, 2022

[video_player] Publish fully federation version

93e70a2

Publishes the change from in-package Android and iOS implementations to federated implementations. Part of flutter/flutter#68498

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Feb 2, 2022

[video_player] Publish fully federation version

d0581a4

Publishes the change from in-package Android and iOS implementations to federated implementations. Part of flutter/flutter#68498

stuartmorgan mentioned this issue Feb 2, 2022

[video_player] Publish fully federation version flutter/plugins#4724

Merged

11 tasks

stuartmorgan mentioned this issue Mar 4, 2022

[quick_actions] Publish federated version flutter/plugins#5005

Merged

11 tasks

stuartmorgan mentioned this issue Mar 22, 2022

[image_picker] Federate mobile implementations flutter/plugins#5100

Merged

11 tasks

swift-kim mentioned this issue Apr 5, 2022

Avoid use of shared method channels flutter-tizen/plugins#348

Closed

4 tasks

stuartmorgan mentioned this issue Apr 5, 2022

[image_picker] Publish federated version flutter/plugins#5174

Merged

11 tasks

stuartmorgan mentioned this issue Apr 8, 2022

[google_sign_in] Federate mobile implementations flutter/plugins#5214

Merged

11 tasks

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Apr 12, 2022

[google_sign_in] Publish federation

d69e47c

Restores the app-facing package to a publishable state, switch to the newly published federated mobile versions. Part of flutter/flutter#68498

stuartmorgan mentioned this issue Apr 12, 2022

[google_sign_in] Publish federation flutter/plugins#5238

Merged

11 tasks

stuartmorgan mentioned this issue Jun 8, 2022

[camera] Federate mobile implementations flutter/plugins#5937

Merged

11 tasks

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Jun 9, 2022

[camera] Publish federated implementations

02de8b6

Re-enables publishing of `camera` now that the mobile federated implementation packages have been published. Part of flutter/flutter#68498

stuartmorgan mentioned this issue Jun 9, 2022

[camera] Publish federated implementations flutter/plugins#5942

Merged

11 tasks

stuartmorgan mentioned this issue Jul 18, 2022

[google_maps_flutter] Use an interface for test inspection flutter/plugins#6116

Merged

11 tasks

stuartmorgan mentioned this issue Aug 2, 2022

[google_maps_flutter] Federate mobile implementations flutter/plugins#6171

Merged

11 tasks

auto-submit bot closed this as completed in flutter/plugins#6171 Aug 3, 2022

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Aug 4, 2022

[google_maps_flutter] Publish federation

4086b4a

Restored the app-facing package to publishable state, using the newly-published federated mobile implementations. Part of flutter/flutter#68498

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Aug 4, 2022

[google_maps_flutter] Publish federation

8901323

Restored the app-facing package to publishable state, using the newly-published federated mobile implementations. Part of flutter/flutter#68498

stuartmorgan mentioned this issue Aug 4, 2022

[google_maps_flutter] Publish federation flutter/plugins#6204

Merged

11 tasks

stuartmorgan added a commit to flutter/plugins that referenced this issue Aug 17, 2022

[google_maps_flutter] Publish federation (#6204)

0d3d520

Restored the app-facing package to publishable state, using the newly-published federated mobile implementations. Part of flutter/flutter#68498

github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022

flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Federate the Android and iOS implementations of 1P plugins #68498

Federate the Android and iOS implementations of 1P plugins #68498

MisterJimson commented Oct 19, 2020

stuartmorgan commented Oct 19, 2020 •

edited

Sunbreak commented Aug 14, 2021

stuartmorgan commented Aug 14, 2021

stuartmorgan commented Mar 22, 2022

github-actions bot commented Aug 17, 2022

Federate the Android and iOS implementations of 1P plugins #68498

Federate the Android and iOS implementations of 1P plugins #68498

Comments

MisterJimson commented Oct 19, 2020

Use case

Proposal

stuartmorgan commented Oct 19, 2020 • edited

Sunbreak commented Aug 14, 2021

stuartmorgan commented Aug 14, 2021

stuartmorgan commented Mar 22, 2022

github-actions bot commented Aug 17, 2022

stuartmorgan commented Oct 19, 2020 •

edited