Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas constructor crashes with bad arguments #70

Closed
FlutterIssues opened this issue Nov 9, 2015 · 3 comments
Closed

Canvas constructor crashes with bad arguments #70

FlutterIssues opened this issue Nov 9, 2015 · 3 comments
Labels
c: crash Stack traces logged to the console engine flutter/engine repository. See also e: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Comments

@FlutterIssues
Copy link

Issue by Hixie
Thursday Jul 16, 2015 at 22:25 GMT
Originally opened as https://github.com/flutter/engine/issues/23


From @Hixie on July 15, 2015 21:0

My reading of the Canvas constructor is that it'll crash if you call it with a null first argument.
The comment also explicitly says that it'll crash if you call it with a PictureRecorder in the wrong state.

The APIs the C++ expose to the Dart code should never be able to crash the app.

Copied from original issue: domokit/mojo#326

@FlutterIssues FlutterIssues added bug c: crash Stack traces logged to the console engine flutter/engine repository. See also e: labels. labels Nov 9, 2015
@Hixie Hixie removed the ⚠ bug label Dec 12, 2015
@Hixie Hixie modified the milestone: Blue Sky Dec 16, 2015
@sethladd sethladd added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 14, 2016
@sethladd
Copy link
Contributor

Is this still an issue?

@Hixie
Copy link
Contributor

Hixie commented Sep 14, 2016

The first case listed here is fixed. The second is also filed as #2531, so I'll close this one.

@Hixie Hixie closed this as completed Sep 14, 2016
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: crash Stack traces logged to the console engine flutter/engine repository. See also e: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds
Projects
None yet
Development

No branches or pull requests

3 participants