Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar width is way to big compared to native mobile behavior #72202

Closed
LasseRosenow opened this issue Dec 12, 2020 · 11 comments · Fixed by #72531
Closed

Scrollbar width is way to big compared to native mobile behavior #72202

LasseRosenow opened this issue Dec 12, 2020 · 11 comments · Fixed by #72531
Assignees
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Comments

@LasseRosenow
Copy link
Contributor

The current scrollbar implementation has a width of 8, but native android apps have scrollbars with a width of something like 4.
Ther current scrollbar looks very big and weird to me.

Use case

Changing the scrollbar width would make flutter look much more consistent to native android applications.

Proposal

Change the scrollbar width for android to 4.0.

@asterix11
Copy link

Please handle this issue very soon, it feels very uncomfortable with that king size scrollbar currently served.

@TahaTesser
Copy link
Member

Hi @lazylazyllama
Can you please provide visual comparison and documentation if possible
Thank you

@TahaTesser TahaTesser added in triage Presently being triaged by the triage team waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds labels Dec 14, 2020
@Piinks
Copy link
Contributor

Piinks commented Dec 14, 2020

@lazylazyllama the default scrollbar thickness is in line with Material Design specifications, there is a way to change the default though. You can set Scrollbar.thickness to the desired value.

@HansMuller HansMuller added f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: proposal A detailed proposal for a change to Flutter labels Dec 14, 2020
@HansMuller
Copy link
Contributor

Should the default scrollbar thickness "adapt" to the underlying platform?

@Piinks
Copy link
Contributor

Piinks commented Dec 14, 2020

Should the default scrollbar thickness "adapt" to the underlying platform?

I have reached out to the design team to ask exactly that question! :)

@TahaTesser TahaTesser added passed first triage and removed in triage Presently being triaged by the triage team waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds labels Dec 14, 2020
@LasseRosenow
Copy link
Contributor Author

@lazylazyllama the default scrollbar thickness is in line with Material Design specifications, there is a way to change the default though. You can set Scrollbar.thickness to the desired value.

So that means that the native android implementation breaks with the current material design? Because in every native app the scrollbar is much thinner 🤔

@LasseRosenow
Copy link
Contributor Author

LasseRosenow commented Dec 14, 2020

@Piinks are you sure, the material design team was talking about the basic scrollbar width on Android and not the draggable? Because it makes sense for the draggable scrollbar to have a higher width, but the default scrollbar on Android is not draggable and thus way thinner

@Piinks
Copy link
Contributor

Piinks commented Dec 14, 2020

the default scrollbar on Android is not draggable and thus way thinner

That is correct! I just heard back on my inquiry to the design team. The difference is in interaction vs. a visual indicator. We can add a separate thickness for a passive/indicator Scrollbar, and apply it automatically when we do not have a ScrollController - which is required for dragging and tapping on the scrollbar.

WDYT @lazylazyllama?

I am also working on a ScrollbarTheme (#72308) right now, so we can factor this into that as well, so any desirable thickness in any state can be achieved across the whole app. :)

@LasseRosenow
Copy link
Contributor Author

@Piinks That sounds very good :) I'm looking forward to it 😊

@Piinks Piinks self-assigned this Dec 15, 2020
@LasseRosenow
Copy link
Contributor Author

Actually what I just thought of: On the web scrollbars are draggable by default, so will they automatically get a Scrollcontroller on the web? Or do we have to add them with conditional statements to check the current platform?

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants