Update Scrollbar behavior for mobile devices #72531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
framework
flutter-dashboard
bot
added
the
f: material design
Piinks
commented
Dec 17, 2020
9 tasks
xu-baolin
reviewed
Dec 21, 2020
| // Hover events not supported on mobile. | ||
| child = MouseRegion( | ||
| onExit: handleHoverExit, | ||
| onHover: handleHover, |
There was a problem hiding this comment.
We can use PointerEvent.kind to distinguish the type of input device to deal with this issue. Moreover, the mobile phone can also be used with an external mouse. At this time, we can better respond to the hover event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up change to #71664
The new material scrollbar needs a few mobile-specific updates.
First, the scrollbar should be thinner on mobile because of the relative size of the screen.
On Android specifically, we should be matching native instead of Material Design.
Finally, on mobile, we should be ignoring hover events. You can trigger a hover enter event with taps on mobile, but you cannot trigger the hover exit event, which the behaviors of the scrollbar relies on.
Related Issues
Fixes #72202
#70866
Tests
Updated affected tests, added tests for platform specific behaviors.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.