Deprecated obsolete Material classes: FlatButton, RaisedButton, OutlineButton #73352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: cupertino
Piinks
approved these changes
Jan 5, 2021
| @@ -108,6 +108,10 @@ import 'theme_data.dart'; | |||
| /// * [RawMaterialButton], the widget this widget is based on. | |||
| /// * <https://material.io/design/components/buttons.html> | |||
| /// * Cookbook: [Build a form with validation](https://flutter.dev/docs/cookbook/forms/validation) | |||
| @Deprecated( | |||
| 'Use TextButton instead. See the migration guide in flutter.dev/go/material-button-migration-guide). ' | |||
| 'This feature was deprecated after 1.25.0-8.1.pre' | |||
There was a problem hiding this comment.
Suggested change
| 'This feature was deprecated after 1.25.0-8.1.pre' | |
| 'This feature was deprecated after v1.25.0-8.1.pre.' |
Here and below, I think this is the format the linter is looking for.
There was a problem hiding this comment.
Thanks, hopefully I've finally got it.
HansMuller
force-pushed
the
deprecate_obsolete_button_classes
branch
from
ddf3d08
to
2d79ced
Compare
This was referenced Jan 6, 2021
HansMuller
force-pushed
the
deprecate_obsolete_button_classes
branch
2 times, most recently
from
bf02b74
to
3f404b5
Compare
HansMuller
force-pushed
the
deprecate_obsolete_button_classes
branch
from
3f404b5
to
865d41b
Compare
This was referenced Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates three obsolete Material button classes: FlatButton, RaisedButton, OutlineButton. It does not (yet) deprecate the obsolete ButtonTheme and ButtonThemeData classes because there's one remaining reference in _DropDownButtonState. The ButtonTheme classes will be deprecated shortly.
FlatButton, RaisedButton, and OutlineButton have been replaced by TextButton, ElevatedButton, and OutlinedButton respectively. ButtonTheme has been replaced by TextButtonTheme, ElevatedButtonTheme, and OutlinedButtonTheme. The original classes will eventually be removed, please migrate code that uses them. There's a detailed migration guide for the new button and button theme classes in flutter.dev/go/material-button-migration-guide.